Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759241Ab3DAV6h (ORCPT ); Mon, 1 Apr 2013 17:58:37 -0400 Received: from smtp.snhosting.dk ([87.238.248.203]:20204 "EHLO smtp.domainteam.dk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758195Ab3DAV6g (ORCPT ); Mon, 1 Apr 2013 17:58:36 -0400 Date: Mon, 1 Apr 2013 23:58:34 +0200 From: Sam Ravnborg To: "George G. Davis" Cc: Vincent Sanders , Arnd Bergmann , linux-kernel@vger.kernel.org, Vincent Sanders , Andrew Morton , linux-arm-kernel@lists.infradead.org, Russell King - ARM Linux Subject: Re: [PATCH 1/2] Allow constructor name selection by architecture. Message-ID: <20130401215834.GA5972@merkur.ravnborg.org> References: <1338230018-31052-1-git-send-email-vincent.sanders@collabora.co.uk> <1338230018-31052-2-git-send-email-vincent.sanders@collabora.co.uk> <20120528203005.GA20560@merkur.ravnborg.org> <20120529090614.GD12217@n2100.arm.linux.org.uk> <20120606101253.GM8262@n2100.arm.linux.org.uk> <87F2CC87-0FAF-49CB-AE70-423FB063A0E5@mvista.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87F2CC87-0FAF-49CB-AE70-423FB063A0E5@mvista.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2276 Lines: 54 On Mon, Apr 01, 2013 at 05:47:38PM -0400, George G. Davis wrote: > On Jun 6, 2012, at 6:12 AM, Russell King - ARM Linux wrote: > > On Tue, May 29, 2012 at 10:06:14AM +0100, Russell King - ARM Linux wrote: > >> On Mon, May 28, 2012 at 10:30:05PM +0200, Sam Ravnborg wrote: > >>> On Mon, May 28, 2012 at 07:33:37PM +0100, Vincent Sanders wrote: > >>>> From: Vincent Sanders > >>>> > >>>> The constructor symbol name is different between platforms. Allow this > >>>> to be selected by configuration and set suitable default values. > >>>> > >>>> Signed-off-by: Vincent Sanders > >>>> --- > >>>> include/asm-generic/vmlinux.lds.h | 6 +++--- > >>>> init/Kconfig | 6 ++++++ > >>>> kernel/module.c | 2 +- > >>>> 3 files changed, 10 insertions(+), 4 deletions(-) > >>>> > >>>> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h > >>>> index 8aeadf6..fd34808 100644 > >>>> --- a/include/asm-generic/vmlinux.lds.h > >>>> +++ b/include/asm-generic/vmlinux.lds.h > >>>> @@ -471,9 +471,9 @@ > >>>> } > >>>> > >>>> #ifdef CONFIG_CONSTRUCTORS > >>>> -#define KERNEL_CTORS() . = ALIGN(8); \ > >>>> - VMLINUX_SYMBOL(__ctors_start) = .; \ > >>>> - *(.ctors) \ > >>>> +#define KERNEL_CTORS() . = ALIGN(8); \ > >>>> + VMLINUX_SYMBOL(__ctors_start) = .; \ > >>>> + *(CONFIG_CONSTRUCTORS_NAME) \ > >>>> VMLINUX_SYMBOL(__ctors_end) = .; > >>> > >>> What is wrong with adding both "standard" names for ctors uncnditionally? > >>> Like this: > >>>> *(.ctors) \ > >>>> + *(.init_array) \ > >> > >> That doesn't get rid of CONFIG_CONSTRUCTORS_NAME, because it's needed > >> in the module code. Do you have a suggestion to solve that as well? > > > > Ping. > > Pinging this back to life. I'd like to see GCOV for ARM eABI finally make it upstream. > So, any objections to this? Should it be resubmitted? Why is CONFIG_CONSTRUCTORS_NAME needed in module code? Sam -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/