Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758833Ab3DAWXh (ORCPT ); Mon, 1 Apr 2013 18:23:37 -0400 Received: from mga02.intel.com ([134.134.136.20]:21633 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756857Ab3DAWXf convert rfc822-to-8bit (ORCPT ); Mon, 1 Apr 2013 18:23:35 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,387,1363158000"; d="scan'208";a="287883979" From: "Luck, Tony" To: Yijing Wang , Bjorn Helgaas CC: "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Hanjun Guo , "jiang.liu@huawei.com" , "Yu, Fenghua" , Yinghai Lu , Greg Kroah-Hartman , Thierry Reding , "Wysocki, Rafael J" Subject: RE: [PATCH 2/2] PCI/IA64: fix pci_dev->enable_cnt balance when doing pci hotplug Thread-Topic: [PATCH 2/2] PCI/IA64: fix pci_dev->enable_cnt balance when doing pci hotplug Thread-Index: AQHOLrUMFFEjeq7TGE6qhHVop7NyBpjB8KlQ Date: Mon, 1 Apr 2013 22:23:32 +0000 Message-ID: <3908561D78D1C84285E8C5FCA982C28F1E096033@ORSMSX108.amr.corp.intel.com> References: <1364805775-12396-1-git-send-email-wangyijing@huawei.com> <1364805775-12396-2-git-send-email-wangyijing@huawei.com> In-Reply-To: <1364805775-12396-2-git-send-email-wangyijing@huawei.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 667 Lines: 17 > In IA64 platform, we don't call pci_enable_bridges() > when scan all pci buses during system boot up. But in > X86 we do it in Your patch looks plausible ... but I have a question. X86 doesn't *directly* call pci_enable_bridges() from any arch/x86/* file. Do we need this in an arch/ia64 file because our PCI support is getting old and stale? "git grep" says that arm, m68k, mips and sh all make direct calls. -Tony -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/