Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759085Ab3DAWXo (ORCPT ); Mon, 1 Apr 2013 18:23:44 -0400 Received: from violet.fr.zoreil.com ([92.243.8.30]:37003 "EHLO violet.fr.zoreil.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757895Ab3DAWXl (ORCPT ); Mon, 1 Apr 2013 18:23:41 -0400 Date: Tue, 2 Apr 2013 00:23:35 +0200 From: Francois Romieu To: Hayes Wang Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E Message-ID: <20130401222335.GC19335@electric-eye.fr.zoreil.com> References: <1364824539-4156-1-git-send-email-hayeswang@realtek.com> <1364824539-4156-6-git-send-email-hayeswang@realtek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1364824539-4156-6-git-send-email-hayeswang@realtek.com> X-Organisation: Land of Sunshine Inc. User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1482 Lines: 43 Hayes Wang : [...] > - move rtl_set_rx_tx_desc_registers to avoid the tx/rx are enabled > before setting desc registers. This is a wholesale change for the 810x family. Please explain why issuing rtl_set_rx_tx_desc_registers before writing ChipCmd is not enough and feed it through a standalone commit. > Signed-off-by: Hayes Wang > --- > drivers/net/ethernet/realtek/r8169.c | 25 +++++++++++++++++++++++-- > 1 file changed, 23 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c > index 8d41508..876e088 100644 > --- a/drivers/net/ethernet/realtek/r8169.c > +++ b/drivers/net/ethernet/realtek/r8169.c > @@ -49,6 +49,7 @@ > #define FIRMWARE_8106E_1 "rtl_nic/rtl8106e-1.fw" > #define FIRMWARE_8168G_2 "rtl_nic/rtl8168g-2.fw" > #define FIRMWARE_8168G_3 "rtl_nic/rtl8168g-3.fw" > +#define FIRMWARE_8106E_2 "rtl_nic/rtl8106e-2.fw" I'd rather keep those sorted. [...] > @@ -824,6 +829,7 @@ MODULE_FIRMWARE(FIRMWARE_8411_1); > MODULE_FIRMWARE(FIRMWARE_8106E_1); > MODULE_FIRMWARE(FIRMWARE_8168G_2); > MODULE_FIRMWARE(FIRMWARE_8168G_3); > +MODULE_FIRMWARE(FIRMWARE_8106E_2); Same thing as above. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/