Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760079Ab3DBC7c (ORCPT ); Mon, 1 Apr 2013 22:59:32 -0400 Received: from rtits2.realtek.com ([60.250.210.242]:50559 "EHLO rtits2.realtek.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758159Ab3DBC7b (ORCPT ); Mon, 1 Apr 2013 22:59:31 -0400 X-SpamFilter-By: BOX Solutions SpamTrap 5.19 with qID r322xOHD030402, This message is released by code: ctlocs8528 From: hayeswang To: "'Francois Romieu'" CC: , References: <1364824539-4156-1-git-send-email-hayeswang@realtek.com> <1364824539-4156-6-git-send-email-hayeswang@realtek.com> <20130401222335.GC19335@electric-eye.fr.zoreil.com> Subject: RE: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E Date: Tue, 2 Apr 2013 10:59:29 +0800 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Office Outlook 11 Thread-Index: Ac4vJ4/KxyScUuqfStWPuKtkU1h8mgAI15uw In-Reply-To: <20130401222335.GC19335@electric-eye.fr.zoreil.com> X-MimeOLE: Produced By Microsoft MimeOLE V6.00.2900.6157 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1285 Lines: 32 Francois Romieu [mailto:romieu@fr.zoreil.com] > Sent: Tuesday, April 02, 2013 6:24 AM > To: Hayeswang > Cc: netdev@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH net-next 6/7] r8169: add a new chip for RTL8106E > > Hayes Wang : > [...] > > - move rtl_set_rx_tx_desc_registers to avoid the tx/rx are enabled > > before setting desc registers. > > This is a wholesale change for the 810x family. > > Please explain why issuing rtl_set_rx_tx_desc_registers before writing > ChipCmd is not enough and feed it through a standalone commit. > According to the new initial flow of this new chip, the tx/rx would be enabled in rtl_hw_start_8168g_2 function. And this function is run before rtl_set_rx_tx_desc_registers. It would be a problem, so I move rtl_set_rx_tx_desc_registers to make sure that the descriptor address would be set before the tx/rx is enabled. It has no influence for the previous chips, and I think the following new chips would base on the new flow. Best Regards, Hayes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/