Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760404Ab3DBFbm (ORCPT ); Tue, 2 Apr 2013 01:31:42 -0400 Received: from mail.southpole.se ([37.247.8.11]:60090 "EHLO mail.southpole.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753235Ab3DBFbk (ORCPT ); Tue, 2 Apr 2013 01:31:40 -0400 MIME-Version: 1.0 In-Reply-To: <1362896833-21104-17-git-send-email-jiang.liu@huawei.com> References: <1362896833-21104-1-git-send-email-jiang.liu@huawei.com> <1362896833-21104-17-git-send-email-jiang.liu@huawei.com> Date: Tue, 2 Apr 2013 07:31:35 +0200 Message-ID: Subject: Re: [PATCH v2, part1 16/29] mm/openrisc: use common help functions to free reserved pages From: Jonas Bonn To: Jiang Liu Cc: Andrew Morton , David Rientjes , Jiang Liu , Wen Congyang , Maciej Rutecki , Chris Clayton , "Rafael J . Wysocki" , Mel Gorman , Minchan Kim , KAMEZAWA Hiroyuki , Michal Hocko , Jianguo Wu , linux-mm@kvack.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 X-Assp-Version: 2.2.2(12343) on assp.southpole.se X-Assp-Client-SSL: yes X-Assp-Server-TLS: yes X-Assp-ID: assp.southpole.se 80695-12982 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2780 Lines: 85 On 10 March 2013 07:26, Jiang Liu wrote: > Use common help functions to free reserved pages. > Also include to avoid local declarations. > > Signed-off-by: Jiang Liu > Cc: Jonas Bonn Tested and works fine on OpenRISC. Acked-by: Jonas Bonn /Jonas > --- > arch/openrisc/mm/init.c | 27 +++------------------------ > 1 file changed, 3 insertions(+), 24 deletions(-) > > diff --git a/arch/openrisc/mm/init.c b/arch/openrisc/mm/init.c > index e7fdc50..b3cbc67 100644 > --- a/arch/openrisc/mm/init.c > +++ b/arch/openrisc/mm/init.c > @@ -43,6 +43,7 @@ > #include > #include > #include > +#include > > int mem_init_done; > > @@ -201,9 +202,6 @@ void __init paging_init(void) > > /* References to section boundaries */ > > -extern char _stext, _etext, _edata, __bss_start, _end; > -extern char __init_begin, __init_end; > - > static int __init free_pages_init(void) > { > int reservedpages, pfn; > @@ -263,30 +261,11 @@ void __init mem_init(void) > #ifdef CONFIG_BLK_DEV_INITRD > void free_initrd_mem(unsigned long start, unsigned long end) > { > - printk(KERN_INFO "Freeing initrd memory: %ldk freed\n", > - (end - start) >> 10); > - > - for (; start < end; start += PAGE_SIZE) { > - ClearPageReserved(virt_to_page(start)); > - init_page_count(virt_to_page(start)); > - free_page(start); > - totalram_pages++; > - } > + free_reserved_area(start, end, 0, "initrd"); > } > #endif > > void free_initmem(void) > { > - unsigned long addr; > - > - addr = (unsigned long)(&__init_begin); > - for (; addr < (unsigned long)(&__init_end); addr += PAGE_SIZE) { > - ClearPageReserved(virt_to_page(addr)); > - init_page_count(virt_to_page(addr)); > - free_page(addr); > - totalram_pages++; > - } > - printk(KERN_INFO "Freeing unused kernel memory: %luk freed\n", > - ((unsigned long)&__init_end - > - (unsigned long)&__init_begin) >> 10); > + free_initmem_default(0); > } > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/