Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760334Ab3DBMGA (ORCPT ); Tue, 2 Apr 2013 08:06:00 -0400 Received: from mail-ee0-f44.google.com ([74.125.83.44]:54285 "EHLO mail-ee0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750920Ab3DBMF7 (ORCPT ); Tue, 2 Apr 2013 08:05:59 -0400 Date: Tue, 2 Apr 2013 13:05:54 +0100 From: Lee Jones To: Mark Brown Cc: Axel Lin , Bengt Jonsson , Yvan FILLION , Liam Girdwood , linux-kernel@vger.kernel.org Subject: Re: [PATCH] regulator: ab8500: Staticize ab8500_ext_regulator_[init|exit] if !CONFIG_REGULATOR_AB8500_EXT Message-ID: <20130402120554.GB5580@gmail.com> References: <1364862038.15806.1.camel@phoenix> <20130402112740.GI23065@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130402112740.GI23065@opensource.wolfsonmicro.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 996 Lines: 29 On Tue, 02 Apr 2013, Mark Brown wrote: > On Tue, Apr 02, 2013 at 08:20:38AM +0800, Axel Lin wrote: > > Fix below build errors: > > > > LD arch/arm/mach-ux500/built-in.o > > arch/arm/mach-ux500/board-mop500-regulators.o: In function `ab8500_ext_regulator_init': > > Lee? Ah yes, I see what's happened. CONFIG_REGULATOR_AB8500_EXT was used to conditionally build the AB8500 External Regulator driver, but now we just 'build it anyway' on Mark's request. However, the guards are still remaining in some places. Please don't action this patch. I'll fix it up properly by removing the surplus guards. -- Lee Jones Linaro ST-Ericsson Landing Team Lead Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/