Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762129Ab3DBSdj (ORCPT ); Tue, 2 Apr 2013 14:33:39 -0400 Received: from iolanthe.rowland.org ([192.131.102.54]:54635 "HELO iolanthe.rowland.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1762102Ab3DBSdh (ORCPT ); Tue, 2 Apr 2013 14:33:37 -0400 Date: Tue, 2 Apr 2013 14:33:36 -0400 (EDT) From: Alan Stern X-X-Sender: stern@iolanthe.rowland.org To: Florian Fainelli cc: linux-kernel@vger.kernel.org, , , Subject: Re: [PATCH 3/5 v2] USB: enclose EHCI HCD drivers within an if USB_EHCI_HCD block In-Reply-To: <1364922626-32407-4-git-send-email-florian@openwrt.org> Message-ID: MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 951 Lines: 26 On Tue, 2 Apr 2013, Florian Fainelli wrote: > Thist patch removes the depends on USB_EHCI_HCD that the various USB > EHCI HCD drivers use and encloses every driver within an if USB_EHCI_HCD > / endif block. The EHCI HCD platform and Octeon drivers have been moved > around to remain enclosed within this block. > > Signed-off-by: Florian Fainelli Okay except for two things. First, you missed the USB_EHCI_BIG_ENDIAN_DESC entry. Second, the Kconfig file has this right in the middle of the section you changed: config USB_FSL_MPH_DR_OF tristate It's probably a mistake to put this under the "if USB_EHCI_HCD" umbrella. I guess it should be moved out of the way. Alan Stern -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/