Message-id: <1364958193.4353.4.camel@kjgkr>
Subject: Re: [PATCH] To add NULL pointer check
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: P J P <ppandit@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Petr Matousek <pmatouse@redhat.com>
Date: Wed, 03 Apr 2013 12:03:13 +0900
In-reply-to: <alpine.LFD.2.03.1304021808410.12716@erqung.pbz>
References: <alpine.LFD.2.03.1304021808410.12716@erqung.pbz>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-UvUkb36I32Rq6rhPKFed"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 3079
Lines: 97


--=-UvUkb36I32Rq6rhPKFed
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,
Thank you for your contribution.

As I consider the null pointer check, generic_writepages() originally
does so.
Therefore, I think f2fs_write_data_pages() is better to handle this.
Please review the modified patch.=20
Thanks,

---
=46rom d3c811a51c7062fb1b66bec910ed346447c02032 Mon Sep 17 00:00:00 2001
From: P J P <ppandit@redhat.com>
Date: Wed, 3 Apr 2013 11:38:00 +0900
Subject: [PATCH] f2fs: add NULL pointer check
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net

Commit - fa9150a84c - replaces a call to generic_writepages() in
f2fs_write_data_pages() with write_cache_pages(), with a function
pointer
argument pointing to routine: __f2fs_writepage.

  ->
https://git.kernel.org/linus/fa9150a84ca333f68127097c4fa1eda4b3913a22

  This patch adds a NULL pointer check in f2fs_write_data_pages() to
avoid
  a possible NULL pointer dereference, in case if -
mapping->a_ops->writepage -
  is NULL.

Signed-off-by: P J P <ppandit@redhat.com>
Signed-off-by: Jaegeuk Kim <jaegeuk.kim@samsung.com>
---
 fs/f2fs/data.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/fs/f2fs/data.c b/fs/f2fs/data.c
index 47a2d7c..cf9ff5f 100644
--- a/fs/f2fs/data.c
+++ b/fs/f2fs/data.c
@@ -559,6 +559,10 @@ static int f2fs_write_data_pages(struct
address_space *mapping,
 	int ret;
 	long excess_nrtw =3D 0, desired_nrtw;
=20
+	/* deal with chardevs and other special file */
+	if (!mapping->a_ops->writepage)
+		return 0;
+
 	if (wbc->nr_to_write < MAX_DESIRED_PAGES_WP) {
 		desired_nrtw =3D MAX_DESIRED_PAGES_WP;
 		excess_nrtw =3D desired_nrtw - wbc->nr_to_write;
--=20
1.8.1.3.566.gaa39828


--=20
Jaegeuk Kim
Samsung

--=-UvUkb36I32Rq6rhPKFed
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRW5vxAAoJEEAUqH6CSFDSy6UP/iUm0OlWK0nDNnKQcX1syJbH
ki+Nb1uy9+XzNcXqCQ4GxH4SRqpJwGmOfYMko8GKdEYhmheUoKdWlmLMOX9oE3bO
AvGA7X9146iIqAZw1iC2bz5pYldUOrW3/wUn5glnUaxY8LVutq57384vIAtEMLmH
O3K4wra0A6OTyh/VWOkYbAiS9wesmjMye+gSEx2QxcAXeb1gq3noqj0sCj1CF1oq
lzSqT6r+UUdCojdfrmdgtpNkBV2peox5ROytkX+mLyDTUaQ6SUoVs8hRt9cD2+DA
zn3KiEvBE2VtwLr0yZHGU5baHWJXhLicDgeZZTnZp3KqGpfPIDORj1uCO2muM9Jk
pZLSHpLR+jdto5Kc1kZH44kvMYSbLeqx3dbMKfxjpvo9V1yXoVyJSa2kEM3LhHyr
x5Flzs+W7wnKhgF9vM5+bq/3EU6PVO/d5RiNp6MgwqUlAD6H2k+xmBiGWVDfRipm
X0g5mF7r18xFdeog1KD3UQ7LydtxNerNmzOi3iA0162i8ieuHwmtr83j2u+5w9w/
qa9pNVFaRGjkw1ZZeSEmWaJZN7je9Rf5/nHk2jBXNadC/QNMddeQBWpNjBks2AvR
UtSyrnNiCL/HkDI69s6uX6Ilh5lf0jHGLqpu6q7Ebt4NZ0W9OrqCFwaTeW8iGd8U
OIuIkMncuo7Q3dPAm84g
=6kVW
-----END PGP SIGNATURE-----

--=-UvUkb36I32Rq6rhPKFed--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/