Message-ID: <515BC0F6.6060903@intel.com>
Date: Wed, 03 Apr 2013 13:41:10 +0800
From: Alex Shi <alex.shi@intel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130221 Thunderbird/17.0.3
MIME-Version: 1.0
To: Namhyung Kim <namhyung@kernel.org>
CC: mingo@redhat.com, peterz@infradead.org, tglx@linutronix.de,
        akpm@linux-foundation.org, arjan@linux.intel.com, bp@alien8.de,
        pjt@google.com, efault@gmx.de, vincent.guittot@linaro.org,
        gregkh@linuxfoundation.org, preeti@linux.vnet.ibm.com,
        viresh.kumar@linaro.org, linux-kernel@vger.kernel.org
Subject: Re: [patch v6 13/21] sched: using avg_idle to detect bursty wakeup
References: <1364654108-16307-1-git-send-email-alex.shi@intel.com> <1364654108-16307-14-git-send-email-alex.shi@intel.com> <876204fbgu.fsf@sejong.aot.lge.com>
In-Reply-To: <876204fbgu.fsf@sejong.aot.lge.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1405
Lines: 48

	struct rq *rq = cpu_rq(i);
>> +
>> +		if (burst && rq->nr_running > 1)
>> +			/* use nr_running as instant utilization */
>> +			sgs->group_util += rq->nr_running;
> 
> I guess multiplying FULL_UTIL to rq->nr_running here will remove
> special-casing the burst in is_sd_full().  Also moving this logic to
> max_rq_util() looks better IMHO.

Yes, right! Thanks a lot!
> 
> 

>> +	if (cpu_rq(cpu)->avg_idle < sysctl_sched_burst_threshold)
>> +		burst = 1;
> 
> Sorry, I don't understand this.
> 
> Given that sysctl_sched_burst_threshold is twice of
> sysctl_sched_migration_cost which is max value of rq->avg_idle, the
> avg_idle will be almost always less than the threshold, right?

In fact, lots of time we have avg_idle at the max value. so won't always
have burst.
> 
> So how does it find out the burst case?  I thought it's the case of a
> cpu is in idle for a while and then wakes number of tasks at once.

Yes.
  If
> so, shouldn't it check whether the avg_idle is *longer* than certain
> threshold?  What am I missing?

avg_idle is smaller when many wakeup happens. update_avg() is not always
increase it.
> 
> Thanks,
> Namhyung
> 

-- 
Thanks Alex
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/