Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760475Ab3DCMSl (ORCPT ); Wed, 3 Apr 2013 08:18:41 -0400 Received: from mail-ea0-f170.google.com ([209.85.215.170]:49944 "EHLO mail-ea0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759519Ab3DCMSj (ORCPT ); Wed, 3 Apr 2013 08:18:39 -0400 Message-ID: <515C1E0C.4070306@openwrt.org> Date: Wed, 03 Apr 2013 14:18:20 +0200 From: Florian Fainelli Organization: OpenWrt User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: balbi@ti.com CC: Alan Stern , Kernel development list , arnd@arndb.de, gregkh@linuxfoundation.org, USB list Subject: Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USB block References: <515C1C61.50301@openwrt.org> <20130403121503.GY25837@arwen.pp.htv.fi> In-Reply-To: <20130403121503.GY25837@arwen.pp.htv.fi> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1702 Lines: 38 Le 04/03/13 14:15, Felipe Balbi a écrit : > On Wed, Apr 03, 2013 at 02:11:13PM +0200, Florian Fainelli wrote: >> Le 04/02/13 20:06, Alan Stern a écrit : >>> On Tue, 2 Apr 2013, Florian Fainelli wrote: >>> >>>> This patch removes the depends on USB from all config symbols in >>>> drivers/usb/host/Kconfig and replace that with an if USB / endif block >>>> as suggested by Alan Stern. Some source ... Kconfig lines have been >>>> shuffled around to permit a better regroupment of the Kconfig files >>>> depending on "config USB" item. No functionnal change is introduced. >>> >>> This looks almost right. The only problem I see is in >>> drivers/usb/core/Kconfig. The USB_OTG_WHITELIST and >>> USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG, >>> because they can be set if EXPERT is enabled. >>> >>> To avoid these issues, I think the best approach is to move all the >>> USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they >>> should have been all along. >>> >>> Felipe, do you agree? >> >> Make sense, I will make this a sixth patch to this serie if this >> sounds right with you? > > Pleae don't. Look at my 'next' branch. I deleted drivers/usb/otg/ > completely. OTG should be part of usbcore and I have plans of adding > generic (and optional) OTG hooks in there. Ok, then I will leave it as it is now and simply address the comment your made initially, does that fit both you and Alan? Thanks! -- Florian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/