Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762537Ab3DCM1s (ORCPT ); Wed, 3 Apr 2013 08:27:48 -0400 Received: from LGEMRELSE1Q.lge.com ([156.147.1.111]:60530 "EHLO LGEMRELSE1Q.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762257Ab3DCM0a (ORCPT ); Wed, 3 Apr 2013 08:26:30 -0400 X-AuditID: 9c93016f-b7c18ae000002f5f-a5-515c1ff14735 From: Namhyung Kim To: Arnaldo Carvalho de Melo Cc: Peter Zijlstra , Paul Mackerras , Ingo Molnar , Namhyung Kim , LKML , Stephane Eranian , Andi Kleen , Jiri Olsa , David Ahern Subject: [PATCH 07/10] perf sort: Cleanup sort__has_sym setting Date: Wed, 3 Apr 2013 21:26:16 +0900 Message-Id: <1364991979-3008-8-git-send-email-namhyung@kernel.org> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1364991979-3008-1-git-send-email-namhyung@kernel.org> References: <1364991979-3008-1-git-send-email-namhyung@kernel.org> X-Brightmail-Tracker: AAAAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1137 Lines: 35 From: Namhyung Kim The sort__has_sym variable is set only if a symbol-related sort key was added. Since branch stack and memory sort dimensions are separated, it doesn't need to be checked from common dimension. Signed-off-by: Namhyung Kim --- tools/perf/util/sort.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/tools/perf/util/sort.c b/tools/perf/util/sort.c index 7f66c822d8bd..213831133e08 100644 --- a/tools/perf/util/sort.c +++ b/tools/perf/util/sort.c @@ -1016,10 +1016,7 @@ int sort_dimension__add(const char *tok) return -EINVAL; } sort__has_parent = 1; - } else if (sd->entry == &sort_sym || - sd->entry == &sort_sym_from || - sd->entry == &sort_sym_to || - sd->entry == &sort_mem_daddr_sym) { + } else if (sd->entry == &sort_sym) { sort__has_sym = 1; } -- 1.7.11.7 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/