Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762599Ab3DCM37 (ORCPT ); Wed, 3 Apr 2013 08:29:59 -0400 Received: from mail-la0-f53.google.com ([209.85.215.53]:63355 "EHLO mail-la0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762264Ab3DCM36 (ORCPT ); Wed, 3 Apr 2013 08:29:58 -0400 From: Dmitry Monakhov To: "Theodore Ts'o" , Christian Kujau , CAI Qian , LKML , linux-s390 , Steve Best , linux-ext4@vger.kernel.org Subject: Re: [PATCH] ext4: fix a big-endian bug when an extent is zeroed out In-Reply-To: <20130403122058.GB7741@thunk.org> References: <87fvzaspr8.fsf@openvz.org> <874841142.414482.1364875584266.JavaMail.root@redhat.com> <877gkls1q7.fsf@openvz.org> <87r4isd1vn.fsf@openvz.org> <87li90q9mx.fsf@openvz.org> <87hajoq6s2.fsf@openvz.org> <20130403102204.GA15383@gmail.com> <20130403122058.GB7741@thunk.org> User-Agent: Notmuch/0.6.1 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-redhat-linux-gnu) Date: Wed, 03 Apr 2013 16:29:52 +0400 Message-ID: <87bo9vre4f.fsf@openvz.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2030 Lines: 43 On Wed, 3 Apr 2013 08:20:58 -0400, Theodore Ts'o wrote: > On Wed, Apr 03, 2013 at 06:22:04PM +0800, Zheng Liu wrote: > > Subject: [PATCH] ext4: fix a big-endian bug when an extent is zeroed out > > > > From: Zheng Liu > > > > When an extent was zeroed out, we forgot to do convert from cpu to le16. > > It could make us hit a BUG_ON when we try to write dirty pages out. So > > fix it. > > > > Signed-off-by: Zheng Liu > > Thanks for finding this! I think we should push this to Linus right > away, and not wait for the next merge window. The bug has been here > for a long time, but it was unmasked by the fact that we unbroke > extent zeroing in 3.9-rcX. IMHO you have to pick this one http://patchwork.ozlabs.org/patch/233397 because it also fix ext_to_indirect_migration and inode's csum > > I have two big questions. (1) Shouldn't Eric Whitney have picked this > up with his ARM pandaboard testing, since IIRC it's big-endian as > well? If not, is there something we can do to improve our testing wrt > to big-endian systems? > > And (2) does it make sense to have an inline function > ext4_ext_set_len(len)? It might save some lines of code, but more > importantly, it might make it less likely that we will overlook this > sort of bug in the future. Let's live it for now, later I'll cleanup/optimize this 'zero_ex' at least from from ext4_split_extent_at because at the end we are shure that 'ex' is fully mapped and initialized > > - Ted > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/