Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761587Ab3DCP36 (ORCPT ); Wed, 3 Apr 2013 11:29:58 -0400 Received: from mail.active-venture.com ([67.228.131.205]:63829 "EHLO mail.active-venture.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760829Ab3DCP35 (ORCPT ); Wed, 3 Apr 2013 11:29:57 -0400 X-Originating-IP: 108.223.40.66 Date: Wed, 3 Apr 2013 08:30:00 -0700 From: Guenter Roeck To: Sascha Hauer Cc: Christian Gmeiner , LKML , x86@kernel.org, linux-i2c@vger.kernel.org, linux-watchdog@vger.kernel.org, Thomas Gleixner Subject: Re: [PATCH 3/3] watchdog: Add Congatec CGEB watchdog driver Message-ID: <20130403153000.GA30641@roeck-us.net> References: <1360663374-30951-1-git-send-email-s.hauer@pengutronix.de> <1360663374-30951-4-git-send-email-s.hauer@pengutronix.de> <20130326143331.GA5529@roeck-us.net> <20130403150952.GX1906@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130403150952.GX1906@pengutronix.de> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 683 Lines: 19 On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote: [ ... ] > > > > On a side note, if the driver supports devicetree, it might make sense to call > > watchdog_init_timeout, since it initializes the timeout from devicetree data. > > The driver does not support devicetree. > I should have said "the system". Calling watchdog_init_timeout is the only thing a watchdog driver has to do to support devicetree. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/