Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763308Ab3DCUNX (ORCPT ); Wed, 3 Apr 2013 16:13:23 -0400 Received: from mail-wi0-f171.google.com ([209.85.212.171]:43012 "EHLO mail-wi0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762404Ab3DCUNW (ORCPT ); Wed, 3 Apr 2013 16:13:22 -0400 MIME-Version: 1.0 Reply-To: konrad@darnok.org In-Reply-To: <1364984183-9711-2-git-send-email-liwanp@linux.vnet.ibm.com> References: <1364984183-9711-1-git-send-email-liwanp@linux.vnet.ibm.com> <1364984183-9711-2-git-send-email-liwanp@linux.vnet.ibm.com> From: Konrad Rzeszutek Wilk Date: Wed, 3 Apr 2013 16:13:01 -0400 X-Google-Sender-Auth: DtKN4S0le0nhlRQ3JDV2SBPaNoM Message-ID: Subject: Re: [PATCH v6 1/3] staging: zcache: fix static variables defined in debug.h but used in mutiple C files To: Wanpeng Li Cc: Greg Kroah-Hartman , Andrew Morton , Dan Magenheimer , Seth Jennings , Minchan Kim , linux-mm@kvack.org, "linux-kernel@vger.kernel.org" , Geert Uytterhoeven , Fengguang Wu Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 757 Lines: 13 On Wed, Apr 3, 2013 at 6:16 AM, Wanpeng Li wrote: > After commit 95bdaee214 ("zcache: Move debugfs code out of zcache-main.c file") > be merged, most of knods in zcache debugfs just export zero since these variables > are defined in debug.h but are in use in multiple C files zcache-main.c and debug.c, > in this case variables can't be treated as shared variables. > > Signed-off-by: Wanpeng Li Reviewed-by: Konrad Rzeszutek Wilk -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/