Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1763319Ab3DCUm0 (ORCPT ); Wed, 3 Apr 2013 16:42:26 -0400 Received: from mga14.intel.com ([143.182.124.37]:18449 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760603Ab3DCUmZ (ORCPT ); Wed, 3 Apr 2013 16:42:25 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.87,403,1363158000"; d="scan'208";a="222522400" From: Huzefa Kankroliwala To: jkosina@suse.cz Cc: benjamin.tissoires@gmail.com, mika.westerberg@intel.com, linux-kernel@vger.kernel.org, Huzefa Kankroliwala Subject: [PATCH v2] i2c-hid: fix length for set/get report in i2c hid Date: Wed, 3 Apr 2013 05:45:21 -0700 Message-Id: <1364993121-18800-1-git-send-email-huzefa.nomanx.kankroliwala@intel.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2175 Lines: 59 With the current i2c hid driver set/get report does not work as expected, for e.g sensor hub properties like power state, frequency etc is not set properly on the device as a result we do not get events. The problem is that i2c hid driver in function i2c_hid_request sets length equal to default buffer size for which the sensor hub does not respond on get/set commands. Use report length and calculate it based on report size and id. Reviewed-by: Mika Westerberg Reviewed-by: Benjamin Tissoires Signed-off-by: Huzefa Kankroliwala --- drivers/hid/i2c-hid/i2c-hid.c | 9 ++++----- 1 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/hid/i2c-hid/i2c-hid.c b/drivers/hid/i2c-hid/i2c-hid.c index 935f387..2b1799a 100644 --- a/drivers/hid/i2c-hid/i2c-hid.c +++ b/drivers/hid/i2c-hid/i2c-hid.c @@ -567,18 +567,17 @@ static void i2c_hid_request(struct hid_device *hid, struct hid_report *rep, int reqtype) { struct i2c_client *client = hid->driver_data; - struct i2c_hid *ihid = i2c_get_clientdata(client); char *buf; int ret; + int len = i2c_hid_get_report_length(rep) - 2; - buf = kzalloc(ihid->bufsize, GFP_KERNEL); + buf = kzalloc(len, GFP_KERNEL); if (!buf) return; switch (reqtype) { case HID_REQ_GET_REPORT: - ret = i2c_hid_get_raw_report(hid, rep->id, buf, ihid->bufsize, - rep->type); + ret = i2c_hid_get_raw_report(hid, rep->id, buf, len, rep->type); if (ret < 0) dev_err(&client->dev, "%s: unable to get report: %d\n", __func__, ret); @@ -587,7 +586,7 @@ static void i2c_hid_request(struct hid_device *hid, struct hid_report *rep, break; case HID_REQ_SET_REPORT: hid_output_report(rep, buf); - i2c_hid_output_raw_report(hid, buf, ihid->bufsize, rep->type); + i2c_hid_output_raw_report(hid, buf, len, rep->type); break; } -- 1.7.4.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/