Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758606Ab3DDI5q (ORCPT ); Thu, 4 Apr 2013 04:57:46 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:34326 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755462Ab3DDI5l (ORCPT ); Thu, 4 Apr 2013 04:57:41 -0400 Message-ID: <515D4050.7090506@ti.com> Date: Thu, 4 Apr 2013 14:26:48 +0530 From: Kishon Vijay Abraham I User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v5 1/6] drivers: phy: add generic PHY framework References: <1364993634-6378-1-git-send-email-kishon@ti.com> <1364993634-6378-2-git-send-email-kishon@ti.com> <20130403134102.GC14680@arwen.pp.htv.fi> <515C3A42.4020404@ti.com> <20130403142747.GK14680@arwen.pp.htv.fi> <515C3D94.1060000@ti.com> <20130403154704.GD19093@arwen.pp.htv.fi> In-Reply-To: <20130403154704.GD19093@arwen.pp.htv.fi> Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1122 Lines: 37 Hi, On Wednesday 03 April 2013 09:17 PM, Felipe Balbi wrote: > Hi, > > On Wed, Apr 03, 2013 at 08:02:52PM +0530, Kishon Vijay Abraham I wrote: >>>>>> + ret = -EINVAL; >>>>>> + goto err0; >>>>>> + } >>>>>> + >>>>>> + if (!phy_class) >>>>>> + phy_core_init(); >>>>> >>>>> why don't you setup the class on module_init ? Then this would be a >>>>> terrible error condition here :-) >>>> >>>> This is for the case where the PHY driver gets loaded before the PHY >>>> framework. I could have returned EPROBE_DEFER here instead I thought >>>> will have it this way. >>> >>> looks a bit weird IMO. Is it really possible for PHY to load before ? >> >> yeah. it actually happened when I tried with beagle and had all the >> modules as built-in. Because twl4030 has subsys_initcall(), it loads >> before PHY framework. > > that's a bug in twl4030. right. Will fix it. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/