Message-ID: <515D4A7F.5070102@cip.cs.fau.de>
Date: Thu, 04 Apr 2013 11:40:15 +0200
From: Sebastian Wankerl <sisewank@cip.cs.fau.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.12) Gecko/20130116 Icedove/10.0.12
MIME-Version: 1.0
To: Rusty Russell <rusty@rustcorp.com.au>
CC: Sebastian Wankerl <sisewank@cip.cs.fau.de>, linux-kernel@vger.kernel.org,
        Philip Kranz <philip.kranz@googlemail.com>,
        i4passt@lists.informatik.uni-erlangen.de
Subject: Re: [PATCH] Add non-zero module sections to sysfs
References: <1364994499-23708-1-git-send-email-sisewank@cip.cs.fau.de> <87mwtf3ya1.fsf@rustcorp.com.au>
In-Reply-To: <87mwtf3ya1.fsf@rustcorp.com.au>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1379
Lines: 32

On 04/04/13 03:00, Rusty Russell wrote:
> Sebastian Wankerl <sisewank@cip.cs.fau.de> writes:
>> Add non-zero module sections to sysfs on architectures unequal to PARISC.
>> KGDB needs all module sections for proper module debugging. Therefore, commit 
>> 35dead4235e2b67da7275b4122fed37099c2f462 is revoked except for PARISC
>> architecture.
> #ifdef CONFIG_PARISC in the middle of kernel/module.c is super-ugly, and
> wrong.

I don't see why this is wrong. It used to load all sections to sysfs
until the patch mentioned. Actually, it is the PARISC build chain which
is broken.

> My preference would be to fix kgdb.  If the section is empty, what need
> does it have to examine it?

GDB needs to know all sections of the binary and its addresses. It is
generally useful to be able to check up all sections of the binary
regardless if they are empty or not so one can see the binary's
structure. The alternative would be to redo the work by saving the ELF
header in an additional internal data structure that is not exported.
However, this approach is more ugly as it results in code which is
actually redundant.

Thanks,
Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/