Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760200Ab3DDMqJ (ORCPT ); Thu, 4 Apr 2013 08:46:09 -0400 Received: from mail-la0-f42.google.com ([209.85.215.42]:53235 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759788Ab3DDMqG (ORCPT ); Thu, 4 Apr 2013 08:46:06 -0400 MIME-Version: 1.0 In-Reply-To: <20130403144428.GA15432@redhat.com> References: <20130403075017.GA2534@suse.de> <20130403144428.GA15432@redhat.com> Date: Thu, 4 Apr 2013 14:46:05 +0200 Message-ID: Subject: Re: systemtap broken by removal of register_timer_hook From: Frederic Weisbecker To: "Frank Ch. Eigler" Cc: Mel Gorman , Ingo Molnar , LKML , SystemTap Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3202 Lines: 105 2013/4/3 Frank Ch. Eigler : > Hi - > > On Wed, Apr 03, 2013 at 02:49:53PM +0200, Frederic Weisbecker wrote: > >> Sounds good, would you like to propose a version? We are also >> interested in a timer tick event tracepoint for dynticks debugging. > > How about this? > > Author: Frank Ch. Eigler > Date: Wed Apr 3 10:35:21 2013 -0400 > > profiling: add profile_tick tracepoint > > Commit ba6fdda4 removed the timer_hook mechanism for modules to listen > to profiling timer ticks (without having to set up more complicated > perf mechanisms). To reduce the impact on out-of-tree users, a > TRACE_EVENT-flavoured tracepoint is added in its place. Tested with > perf and systemtap. > > Cc: Frederic Weisbecker > Cc: Ingo Molnar > Cc: Mel Gorman > Signed-off-by: Frank Ch. Eigler > > diff --git a/include/trace/events/profile.h b/include/trace/events/profile.h > new file mode 100644 > index 0000000..b48b6fe > --- /dev/null > +++ b/include/trace/events/profile.h > @@ -0,0 +1,35 @@ > +#undef TRACE_SYSTEM > +#define TRACE_SYSTEM profile > + > +#if !defined(_TRACE_PROFILE_H) || defined(TRACE_HEADER_MULTI_READ) > +#define _TRACE_PROFILE_H > + > +#include > + > + > +struct pt_regs; > + > +/** > + * profile_tick - called when the profiling timer ticks > + * @regs: pointer to struct pt_regs* > + */ > + > +TRACE_EVENT(profile_tick, > + TP_PROTO(int type, struct pt_regs *regs), > + TP_ARGS(type, regs), > + TP_STRUCT__entry( > + __field( int, type ) > + __field( struct pt_regs*, regs ) > + ), > + TP_fast_assign( > + __entry->type = type; > + __entry->regs = regs; > + ), > + TP_printk("type=%d regs=%p", __entry->type, __entry->regs) > +); > + > + > +#endif /* _TRACE_PROFILE_H */ > + > +/* This part must be outside protection */ > +#include > diff --git a/kernel/profile.c b/kernel/profile.c > index dc3384e..d61f921 100644 > --- a/kernel/profile.c > +++ b/kernel/profile.c > @@ -29,6 +29,9 @@ > #include > #include > > +#define CREATE_TRACE_POINTS > +#include > + > struct profile_hit { > u32 pc, hits; > }; > @@ -414,6 +417,8 @@ void profile_tick(int type) > { > struct pt_regs *regs = get_irq_regs(); > > + trace_profile_tick(type, regs); > + It would be better not to tie this to CONFIG_PROFILING. A tracepoint in update_process_times() instead would be great but it's sometimes called several times in a tick from some archs. Probably we need something like: static inline tick_trace(struct pt_regs *regs) { trace_timer_tick(regs); profile_tick(CPU_PROFILING); } Then replace all calls to profile_tick() with the above. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/