Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760717Ab3DDNBs (ORCPT ); Thu, 4 Apr 2013 09:01:48 -0400 Received: from hqemgate03.nvidia.com ([216.228.121.140]:8523 "EHLO hqemgate03.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760589Ab3DDNBq convert rfc822-to-8bit (ORCPT ); Thu, 4 Apr 2013 09:01:46 -0400 X-PGP-Universal: processed; by hqnvupgp07.nvidia.com on Thu, 04 Apr 2013 06:00:49 -0700 From: Venu Byravarasu To: Stephen Warren CC: "gregkh@linuxfoundation.org" , "balbi@ti.com" , "stern@rowland.harvard.edu" , "linux-tegra@vger.kernel.org" , "linux-usb@vger.kernel.org" , "linux-kernel@vger.kernel.org" Date: Thu, 4 Apr 2013 18:31:39 +0530 Subject: RE: [PATCH v2 2/7] ARM: tegra: update device trees for USB binding rework Thread-Topic: [PATCH v2 2/7] ARM: tegra: update device trees for USB binding rework Thread-Index: Ac4wn9kSLQIWH5RERdaKt6+GuKlmkQAkEQ+g Message-ID: References: <1364978502-22887-1-git-send-email-vbyravarasu@nvidia.com> <1364978502-22887-3-git-send-email-vbyravarasu@nvidia.com> <515C8024.30204@wwwdotorg.org> In-Reply-To: <515C8024.30204@wwwdotorg.org> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2575 Lines: 67 > -----Original Message----- > From: Stephen Warren [mailto:swarren@wwwdotorg.org] > Sent: Thursday, April 04, 2013 12:47 AM > To: Venu Byravarasu > Cc: gregkh@linuxfoundation.org; balbi@ti.com; > stern@rowland.harvard.edu; linux-tegra@vger.kernel.org; linux- > usb@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH v2 2/7] ARM: tegra: update device trees for USB binding > rework > > On 04/03/2013 02:41 AM, Venu Byravarasu wrote: > > This patch updates all Tegra board files so that they contain all the > > The binding documentation says that the vbus-supply property is required > in all cases. However, many of the DT files still don't have that > property even after this patch. That's inconsistent. Will edit the binding to have the vbus-supply only for otg cases. > > > diff --git a/arch/arm/boot/dts/tegra20-iris-512.dts > b/arch/arm/boot/dts/tegra20-iris-512.dts > > index 52f1103..c99eccc 100644 > > --- a/arch/arm/boot/dts/tegra20-iris-512.dts > > +++ b/arch/arm/boot/dts/tegra20-iris-512.dts > > @@ -41,6 +41,10 @@ > > dr_mode = "otg"; > > }; > > > > + usb-phy@c5000000 { > > + dr_mode = "otg"; > > + }; > > Since this port claims to be OTG-capable, presumably a vbus-supply > property is mandatory here? If you don't know enough about the board to > correctly set up such a regulator, lets just mark this port as host-only > for now; we can switch it back to OTG-mode later once someone implements > the required regulator. This won't lose any functionality, since we > don't support OTG-mode yet anyway. However, it will allow the device > tree to be correct/consistent in the mean time. Agree completely. Will update the patch accordingly and send for review. > > > diff --git a/arch/arm/boot/dts/tegra20-seaboard.dts > b/arch/arm/boot/dts/tegra20-seaboard.dts > > > + usb-phy@c5000000 { > > + vbus-supply = <&vbus_reg>; > > + dr_mode = "otg"; > > + }; > > Where is the nvidia,vbus-gpio property? Since your code changes don't > actually implement use of the vbus-supply property yet, they will expect > the vbus-gpio property to exist in the PHY node. As of now Vbus-gpio is being used by EHCI driver only. As anyways we wanted to use vbus-supply, will implement its support in PHY driver and remove vbus-gpio from EHCI node. Hence did not add vbus-gpio to PHY DT nodes. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/