Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762564Ab3DDO5I (ORCPT ); Thu, 4 Apr 2013 10:57:08 -0400 Received: from seldrel01.sonyericsson.com ([212.209.106.2]:13370 "EHLO seldrel01.sonyericsson.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762538Ab3DDO5F (ORCPT ); Thu, 4 Apr 2013 10:57:05 -0400 From: Oskar Andero Date: Thu, 4 Apr 2013 16:57:02 +0200 To: "linux-kernel@vger.kernel.org" , "linux-input@vger.kernel.org" CC: "dmitry.torokhov@gmail.com" , "Makarov, Aleksej" , Radovan Lekanovic Subject: Re: [PATCH] input: don't call input_dev_release_keys() in resume Message-ID: <20130404145702.GE2481@caracas.corpusers.net> References: <1362664882-16194-1-git-send-email-oskar.andero@sonymobile.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <1362664882-16194-1-git-send-email-oskar.andero@sonymobile.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1409 Lines: 43 On 15:01 Thu 07 Mar , oskar.andero@sonymobile.com wrote: > From: Aleksej Makarov > > When waking up the platform by pressing a specific key, sending a > release on that key makes it impossible to react on the event in > user-space. > > Cc: Dmitry Torokhov > Reviewed-by: Radovan Lekanovic > Signed-off-by: Aleksej Makarov > Signed-off-by: Oskar Andero > --- > drivers/input/input.c | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/drivers/input/input.c b/drivers/input/input.c > index c044699..61ce19f 100644 > --- a/drivers/input/input.c > +++ b/drivers/input/input.c > @@ -1690,7 +1690,10 @@ static int input_dev_resume(struct device *dev) > { > struct input_dev *input_dev = to_input_dev(dev); > > - input_reset_device(input_dev); > + mutex_lock(&input_dev->mutex); > + if (input_dev->users) > + input_dev_toggle(input_dev, true); > + mutex_unlock(&input_dev->mutex); > > return 0; > } > -- > 1.7.8.6 > Ping. Any input on the patch above? -Oskar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/