Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1761143Ab3DDPj1 (ORCPT ); Thu, 4 Apr 2013 11:39:27 -0400 Received: from charlotte.tuxdriver.com ([70.61.120.58]:54595 "EHLO smtp.tuxdriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760168Ab3DDPjZ (ORCPT ); Thu, 4 Apr 2013 11:39:25 -0400 Date: Thu, 4 Apr 2013 11:39:05 -0400 From: Neil Horman To: Bjorn Helgaas Cc: David Woodhouse , Prarit Bhargava , Don Zickus , Jiang Liu , Asit Mallick , "linux-pci@vger.kernel.org" , "linux-kernel@vger.kernel.org" , iommu@lists.linux-foundation.org, Yinghai Lu Subject: Re: [PATCH v2] irq: add quirk for broken interrupt remapping on 55XX chipsets Message-ID: <20130404153905.GB3403@neilslaptop.think-freely.org> References: <1362158276-4901-1-git-send-email-nhorman@tuxdriver.com> <1362423859-18516-1-git-send-email-nhorman@tuxdriver.com> <1365085649.28127.66.camel@i7.infradead.org> <20130404145012.GA3403@neilslaptop.think-freely.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-Spam-Score: -2.9 (--) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1691 Lines: 34 On Thu, Apr 04, 2013 at 08:57:06AM -0600, Bjorn Helgaas wrote: > On Thu, Apr 4, 2013 at 8:50 AM, Neil Horman wrote: > > On Thu, Apr 04, 2013 at 03:27:29PM +0100, David Woodhouse wrote: > >> On Wed, 2013-04-03 at 17:53 -0600, Bjorn Helgaas wrote: > >> > ); > >> > > + > >> > > + if ((revision == 0x13) && irq_remapping_enabled) { > >> > > + pr_warn(HW_ERR "This system BIOS has enabled interrupt remapping\n" > >> > > + "on a chipset that contains an errata making that\n" > >> > > + "feature unstable. Please reboot with nointremap\n" > >> > > + "added to the kernel command line and contact\n" > >> > > + "your BIOS vendor for an update"); > >> > >> This should be WARN_TAINT(TAINT_FIRMWARE_WORKAROUND). And 'an erratum'. > >> > > Ok, copy that. I'll repost shortly > > When you do, please include URLs for any problem reports or bugzillas you have. > Well, those are going to be vendor specific, so I'm not sure we can really do that, at least not in any meaningful way. > I assume Windows "just works" in this situation? No more or less than linux does in this case. The Intel provided errata indicates that the only acceptable workaround is to disable remapping in the BIOS, so I would presume that if a windows system has a BIOS that doesn't implement this fix, its just as exposed as we are. Neil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/