Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1762860Ab3DDQNq (ORCPT ); Thu, 4 Apr 2013 12:13:46 -0400 Received: from mail.skyhub.de ([78.46.96.112]:50712 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762770Ab3DDQNo (ORCPT ); Thu, 4 Apr 2013 12:13:44 -0400 Date: Thu, 4 Apr 2013 18:13:40 +0200 From: Borislav Petkov To: Daniel J Blueman Cc: Tony Luck , Borislav Petkov , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Steffen Persvold Subject: Re: [PATCH] x86, amd, mce: Prevent potential cpu-online oops Message-ID: <20130404161340.GF32271@pd.tnic> Mail-Followup-To: Borislav Petkov , Daniel J Blueman , Tony Luck , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org, Steffen Persvold References: <1365090720-12652-1-git-send-email-daniel@numascale-asia.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <1365090720-12652-1-git-send-email-daniel@numascale-asia.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1185 Lines: 32 On Thu, Apr 04, 2013 at 11:52:00PM +0800, Daniel J Blueman wrote: > On platforms where all Northbridges may not be visible (due to routing, eg on > NumaConnect systems), prevent oopsing due to stale pointer access when > offlining cores. > > Signed-off-by: Steffen Persvold > Signed-off-by: Daniel J Blueman Huh, what's up? This one is almost reverting 21c5e50e15b1a which you wrote in the first place. What's happening? What stale pointer access, where? We have the if (nb ..) guards there. This commit message needs a *lot* more explanation about what's going on and why we're reverting 21c5e50e15b1a. And why the special handling for shared banks? I presume you offline some of the cores and there's a dangling pointer but again, there are the nb validity guards... /me is genuinely confused. -- Regards/Gruss, Boris. Sent from a fat crate under my desk. Formatting is fine. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/