From: Arnd Bergmann <arnd@arndb.de>
To: balbi@ti.com
Subject: Re: [PATCH 1/5 v3] USB: regroup all depends on USB within an if USB block
Date: Thu, 4 Apr 2013 19:42:23 +0000
User-Agent: KMail/1.12.2 (Linux/3.8.0-16-generic; KDE/4.3.2; x86_64; ; )
Cc: Alan Stern <stern@rowland.harvard.edu>,
        Thomas Winischhofer <thomas@winischhofer.net>,
        Florian Fainelli <florian@openwrt.org>,
        Kernel development list <linux-kernel@vger.kernel.org>,
        gregkh@linuxfoundation.org, USB list <linux-usb@vger.kernel.org>
References: <20130404171429.GF5129@arwen.pp.htv.fi> <Pine.LNX.4.44L0.1304041339530.1324-100000@iolanthe.rowland.org> <20130404180229.GA5926@arwen.pp.htv.fi>
In-Reply-To: <20130404180229.GA5926@arwen.pp.htv.fi>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201304041942.23259.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1335
Lines: 34

On Thursday 04 April 2013, Felipe Balbi wrote:
> On Thu, Apr 04, 2013 at 01:42:18PM -0400, Alan Stern wrote:
> > > > diff --git a/drivers/usb/misc/sisusbvga/Kconfig b/drivers/usb/misc/sisusbvga/Kconfig
> > > > index 30ea7ca..0d03a52 100644
> > > > --- a/drivers/usb/misc/sisusbvga/Kconfig
> > > > +++ b/drivers/usb/misc/sisusbvga/Kconfig
> > > > @@ -1,7 +1,7 @@
> > > >  
> > > >  config USB_SISUSBVGA
> > > >   tristate "USB 2.0 SVGA dongle support (Net2280/SiS315)"
> > > > - depends on USB && (USB_MUSB_HDRC || USB_EHCI_HCD)
> > > > + depends on (USB_MUSB_HDRC || USB_EHCI_HCD)
> > > 
> > > is it just me or would everybody agree that depending on MUSB or EHCI
> > > here is wrong ?
> > 
> > That line certainly looks like it could be removed entirely.  Perhaps 
> > the original author can enlighten us.
> > 
> > In any case, it's not relevant to the purpose of this patch set.
> 
> right :-)
> 

Originally it had just "depends on USB_EHCI_HCD" and the text mentions that
it requires USB 2.0, so it probably comes from a time where EHCI was the
only high speed capable USB HCD.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/