Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764074Ab3DDVL7 (ORCPT ); Thu, 4 Apr 2013 17:11:59 -0400 Received: from mail-ie0-f182.google.com ([209.85.223.182]:62005 "EHLO mail-ie0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763812Ab3DDVLz (ORCPT ); Thu, 4 Apr 2013 17:11:55 -0400 MIME-Version: 1.0 In-Reply-To: References: <1362158276-4901-1-git-send-email-nhorman@tuxdriver.com> <1365088091-10862-1-git-send-email-nhorman@tuxdriver.com> <515DB7F6.8010502@redhat.com> <20130404200455.GB19354@hmsreliant.think-freely.org> Date: Thu, 4 Apr 2013 14:11:54 -0700 X-Google-Sender-Auth: 9OHLbnTRNN7z_Aqs-DKguOw3Ln0 Message-ID: Subject: Re: [PATCH v4] irq: add quirk for broken interrupt remapping on 55XX chipsets From: Yinghai Lu To: Bjorn Helgaas Cc: Neil Horman , Don Dutile , Linux Kernel Mailing List , Prarit Bhargava , Don Zickus , Asit Mallick , David Woodhouse , "linux-pci@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1180 Lines: 26 On Thu, Apr 4, 2013 at 1:33 PM, Bjorn Helgaas wrote: >> See my last email to Bjorn. Doing this in early-quirks in such a way that we >> can detect an iommu that has interrupt remapping enabled (so we don't just >> unilaterally print this quirk all the time) requires that we be able to parse >> acpi tables very early in the boot. If you know of how to do that, I can make >> this happen. If not, I suppose another alternative would be to have the early >> quirk set a flag that tells us this is a bogus chip, and if we try to enable irq >> remapping with that flag set, we should fail, and report the error at that time, >> but I'm not sure I like that solution. > > I like that solution :) It seems very simple -- you don't have to > parse any tables or anything. You are right, we don't need to parse any acpi tables. just add one quirk in early-quirk.c to set disable_irq_remap = 1; Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/