Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1764940Ab3DDVdk (ORCPT ); Thu, 4 Apr 2013 17:33:40 -0400 Received: from mail-pb0-f53.google.com ([209.85.160.53]:53794 "EHLO mail-pb0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1764925Ab3DDVdi convert rfc822-to-8bit (ORCPT ); Thu, 4 Apr 2013 17:33:38 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT To: Tushar Behera , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org From: Mike Turquette In-Reply-To: <1364890840-20052-1-git-send-email-tushar.behera@linaro.org> Cc: kgene.kim@samsung.com, patches@linaro.org, Thomas Abraham References: <1364890840-20052-1-git-send-email-tushar.behera@linaro.org> Message-ID: <20130404213331.8665.7028@quantum> User-Agent: alot/0.3.4 Subject: Re: [PATCH] clk: exynos5250: Fix divider values for sclk_mmc{0,1,2,3} Date: Thu, 04 Apr 2013 14:33:31 -0700 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2491 Lines: 53 Quoting Tushar Behera (2013-04-02 01:20:40) > In legacy setup, sclk_mmc{0,1,2,3} used PRE_RATIO bit-field (8-bit wide) > instead of RATIO bit-field (4-bit wide) for dividing clock rate. > > With current common clock setup, we are using RATIO bit-field which > is creating FIFO read errors while accessing eMMC. Changing over to > use PRE_RATIO bit-field fixes this issue. > > dwmmc_exynos 12200000.dwmmc0: data FIFO error (status=00008020) > mmcblk0: error -5 transferring data, sector 1, nr 7, cmd response 0x900, card status 0x0 > end_request: I/O error, dev mmcblk0, sector 1 > > Signed-off-by: Tushar Behera > CC: Thomas Abraham I guess this will be applied through the samsung tree, so: Acked-by: Mike Turquette > --- > > Based on Kukjin's for-next branch. > commit d58f6a153f40 ("Merge branch 'next/clk-exynos-2' into for-next") > > drivers/clk/samsung/clk-exynos5250.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/clk/samsung/clk-exynos5250.c b/drivers/clk/samsung/clk-exynos5250.c > index 1152125..2c46fbd 100644 > --- a/drivers/clk/samsung/clk-exynos5250.c > +++ b/drivers/clk/samsung/clk-exynos5250.c > @@ -274,10 +274,10 @@ struct samsung_div_clock exynos5250_div_clks[] __initdata = { > DIV(none, "div_pcm0", "sclk_audio0", DIV_MAU, 4, 8), > DIV(none, "div_sata", "mout_sata", DIV_FSYS0, 20, 4), > DIV(none, "div_usb3", "mout_usb3", DIV_FSYS0, 24, 4), > - DIV(none, "div_mmc0", "mout_mmc0", DIV_FSYS1, 0, 4), > - DIV(none, "div_mmc1", "mout_mmc1", DIV_FSYS1, 16, 4), > - DIV(none, "div_mmc2", "mout_mmc2", DIV_FSYS2, 0, 4), > - DIV(none, "div_mmc3", "mout_mmc3", DIV_FSYS2, 16, 4), > + DIV(none, "div_mmc0", "mout_mmc0", DIV_FSYS1, 8, 8), > + DIV(none, "div_mmc1", "mout_mmc1", DIV_FSYS1, 24, 8), > + DIV(none, "div_mmc2", "mout_mmc2", DIV_FSYS2, 8, 8), > + DIV(none, "div_mmc3", "mout_mmc3", DIV_FSYS2, 24, 8), > DIV(none, "div_uart0", "mout_uart0", DIV_PERIC0, 0, 4), > DIV(none, "div_uart1", "mout_uart1", DIV_PERIC0, 4, 4), > DIV(none, "div_uart2", "mout_uart2", DIV_PERIC0, 8, 4), > -- > 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/