Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932488Ab3DECYY (ORCPT ); Thu, 4 Apr 2013 22:24:24 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:37782 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932459Ab3DECYX convert rfc822-to-8bit (ORCPT ); Thu, 4 Apr 2013 22:24:23 -0400 MIME-Version: 1.0 Message-ID: <7058b4bf-4473-4755-a017-e32f5389a73f@default> Date: Thu, 4 Apr 2013 19:22:21 -0700 (PDT) From: Dan Magenheimer To: Seth Jennings , Andrew Morton Cc: Greg Kroah-Hartman , Nitin Gupta , Minchan Kim , Konrad Wilk , Robert Jennings , Jenifer Hopper , Mel Gorman , Johannes Weiner , Rik van Riel , Larry Woodman , Benjamin Herrenschmidt , Dave Hansen , Joe Perches , Joonsoo Kim , Cody P Schafer , Hugh Dickens , Paul Mackerras , linux-mm@kvack.org, linux-kernel@vger.kernel.org, devel@driverdev.osuosl.org, Bob Liu Subject: RE: [PATCHv8 5/8] mm: break up swap_writepage() for frontswap backends References: <1365113446-25647-1-git-send-email-sjenning@linux.vnet.ibm.com> <1365113446-25647-6-git-send-email-sjenning@linux.vnet.ibm.com> <515DFF08.3060005@linux.vnet.ibm.com> In-Reply-To: <515DFF08.3060005@linux.vnet.ibm.com> X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.7 (607090) [OL 12.0.6668.5000 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 8BIT X-Source-IP: ucsinet21.oracle.com [156.151.31.93] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2308 Lines: 51 > From: Seth Jennings [mailto:sjenning@linux.vnet.ibm.com] > Subject: Re: [PATCHv8 5/8] mm: break up swap_writepage() for frontswap backends > > On 04/04/2013 05:10 PM, Seth Jennings wrote: > > swap_writepage() is currently where frontswap hooks into the swap > > write path to capture pages with the frontswap_store() function. > > However, if a frontswap backend wants to "resume" the writeback of > > a page to the swap device, it can't call swap_writepage() as > > the page will simply reenter the backend. > > > > This patch separates swap_writepage() into a top and bottom half, the > > bottom half named __swap_writepage() to allow a frontswap backend, > > like zswap, to resume writeback beyond the frontswap_store() hook. > > > > __add_to_swap_cache() is also made non-static so that the page for > > which writeback is to be resumed can be added to the swap cache. > > > > Acked-by: Minchan Kim > > Signed-off-by: Seth Jennings > > Adding Cc Bob Liu. > > I just remembered that Bob had done a repost of the 5 and 6 patches, > outside the zswap thread, with a small change to avoid a checkpatch > warning. I didn't pull that change into my version, but I should have. > > It doesn't make a functional difference, so this patch can still go > forward and the checkpatch warning can be cleaned up in a subsequent > patch. If another revision of the patchset is needed for other > reasons, I'll pull this change into the next version. > > I think Dan and Bob would be ok with their tags being applied to 5 and 6: > > Acked-by: Bob Liu > Reviewed-by: Dan Magenheimer > > That ok? OK with me. I do support these two MM patches as candidates for the 3.10 window since both zswap AND in-tree zcache depend on them, but the silence from Andrew was a bit deafening. Seth, perhaps you could add a #ifdef CONFIG_ZSWAP_WRITEBACK to the zswap code and Kconfig (as zcache has done) and then these two patches in your patchset can be reviewed separately? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/