Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161349Ab3DECgg (ORCPT ); Thu, 4 Apr 2013 22:36:36 -0400 Received: from mail7.hitachi.co.jp ([133.145.228.42]:47219 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964821Ab3DECgf (ORCPT ); Thu, 4 Apr 2013 22:36:35 -0400 Message-ID: <515E38B0.3000102@hitachi.com> Date: Fri, 05 Apr 2013 11:36:32 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 5.2; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Oskar Andero Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, davem@davemloft.net, anil.s.keshavamurthy@intel.com, ananth@in.ibm.com, radovan.lekanovic@sonymobile.com, bjorn.davidsson@sonymobile.com, "yrl.pp-manager.tt@hitachi.com" Subject: Re: [PATCH v2 3/4] kprobes: move x86-specific blacklist symbols to arch directory References: <1365079889-21525-1-git-send-email-oskar.andero@sonymobile.com> <1365079889-21525-4-git-send-email-oskar.andero@sonymobile.com> In-Reply-To: <1365079889-21525-4-git-send-email-oskar.andero@sonymobile.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2517 Lines: 70 (2013/04/04 21:51), Oskar Andero wrote: > From: Björn Davidsson > > The common kprobes blacklist contains x86-specific symbols. > Looking for these in kallsyms takes unnecessary time during startup > on non-X86 platform. The symbols where moved to > arch/x86/kernel/kprobes/core.c. OK, it looks good for me. :) Acked-by: Masami Hiramatsu > > Cc: Masami Hiramatsu > Cc: David S. Miller > Cc: linux-arch@vger.kernel.org > Reviewed-by: Radovan Lekanovic > Signed-off-by: Björn Davidsson > Signed-off-by: Oskar Andero > --- > arch/x86/kernel/kprobes/core.c | 6 +++++- > kernel/kprobes.c | 3 --- > 2 files changed, 5 insertions(+), 4 deletions(-) > > diff --git a/arch/x86/kernel/kprobes/core.c b/arch/x86/kernel/kprobes/core.c > index 4aa71a5..41ce6c1 100644 > --- a/arch/x86/kernel/kprobes/core.c > +++ b/arch/x86/kernel/kprobes/core.c > @@ -65,7 +65,11 @@ void jprobe_return_end(void); > DEFINE_PER_CPU(struct kprobe *, current_kprobe) = NULL; > DEFINE_PER_CPU(struct kprobe_ctlblk, kprobe_ctlblk); > > -const char * const arch_kprobes_blacksyms[] = {}; > +const char * const arch_kprobes_blacksyms[] = { > + "native_get_debugreg", > + "irq_entries_start", > + "common_interrupt", > +}; > const size_t arch_kprobes_blacksyms_size = ARRAY_SIZE(arch_kprobes_blacksyms); > > #define stack_addr(regs) ((unsigned long *)kernel_stack_pointer(regs)) > diff --git a/kernel/kprobes.c b/kernel/kprobes.c > index 7654278..58c9f4e 100644 > --- a/kernel/kprobes.c > +++ b/kernel/kprobes.c > @@ -95,9 +95,6 @@ static raw_spinlock_t *kretprobe_table_lock_ptr(unsigned long hash) > */ > static const char * const common_kprobes_blacksyms[] = { > "preempt_schedule", > - "native_get_debugreg", > - "irq_entries_start", > - "common_interrupt", > "mcount", /* mcount can be called from everywhere */ > }; > static const size_t common_kprobes_blacksyms_size = > -- Masami HIRAMATSU IT Management Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/