Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161940Ab3DEPFP (ORCPT ); Fri, 5 Apr 2013 11:05:15 -0400 Received: from mx1.redhat.com ([209.132.183.28]:33616 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161917Ab3DEPFN (ORCPT ); Fri, 5 Apr 2013 11:05:13 -0400 Date: Fri, 5 Apr 2013 17:01:10 +0200 From: Oleg Nesterov To: Masami Hiramatsu Cc: Srikar Dronamraju , Ananth N Mavinakayanahalli , Steven Rostedt , Anton Arapov , Frederic Weisbecker , Ingo Molnar , linux-kernel@vger.kernel.org Subject: Re: Re: [PATCH 3/4] uprobes/tracing: Kill the pointless local_save_flags/preempt_count calls Message-ID: <20130405150110.GA31300@redhat.com> References: <20130329181520.GA20670@redhat.com> <20130329181545.GA20697@redhat.com> <20130404142522.GC8986@linux.vnet.ibm.com> <515E4938.6090809@hitachi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515E4938.6090809@hitachi.com> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 839 Lines: 25 On 04/05, Masami Hiramatsu wrote: > > Acked-by: Masami Hiramatsu Thanks! Masami, perhaps you can also answer the question I asked in 0/4 marc.info/?l=linux-kernel&m=136458107403835 ? Off-topic question... Why uprobe_perf_func() passes "addr = ip" to perf_trace_buf_submit() ? This just sets perf_sample_data->addr for PERF_SAMPLE_ADDR, do we really need this? and we already have perf_sample_data->ip initialized by perf. kprobe_perf_func() and kretprobe_perf_func() do the same. Once again, I am just curious and this is completely offtopic. Oleg. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/