Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163084Ab3DEXsI (ORCPT ); Fri, 5 Apr 2013 19:48:08 -0400 Received: from mail-pd0-f174.google.com ([209.85.192.174]:49518 "EHLO mail-pd0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162968Ab3DEXsG convert rfc822-to-8bit (ORCPT ); Fri, 5 Apr 2013 19:48:06 -0400 MIME-Version: 1.0 In-Reply-To: <20130405220156.GC31680@kroah.com> References: <515E85C5.7010706@asianux.com> <20130405220156.GC31680@kroah.com> Date: Fri, 5 Apr 2013 16:48:05 -0700 Message-ID: Subject: Re: [PATCH] Staging: Android: looping issue, need break when get value firstly. From: =?ISO-8859-1?Q?Arve_Hj=F8nnev=E5g?= To: Greg KH Cc: Chen Gang , Dan Carpenter , Al Viro , Mirsal Ennaime , LKML Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1013 Lines: 27 On Fri, Apr 5, 2013 at 3:01 PM, Greg KH wrote: > On Fri, Apr 05, 2013 at 04:05:25PM +0800, Chen Gang wrote: >> >> need break when 'target_thread' get value, firstly. >> >> 'tmp' is a stack (thread->transaction_stack), >> if 'proc' was the same between child node and parent node, >> the child would have higher priority than parent. > > Are you sure about this? > > have you tested it? > Theoretically this should not change the behavior. The purpose of this code it to make sure only thread per process is part of a transaction stack, so if it finds more than one transaction with a matching process, they should all point to the same thread object. I think a better change description is needed though. -- Arve Hj?nnev?g -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/