Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757279Ab3DFGAP (ORCPT ); Sat, 6 Apr 2013 02:00:15 -0400 Received: from mail-pb0-f41.google.com ([209.85.160.41]:42303 "EHLO mail-pb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754220Ab3DFGAN (ORCPT ); Sat, 6 Apr 2013 02:00:13 -0400 Date: Fri, 5 Apr 2013 23:00:10 -0700 From: Greg KH To: Arve =?iso-8859-1?B?SGr4bm5lduVn?= Cc: Serban Constantinescu , LKML , Android Kernel Team , John Stultz , Dave Butcher Subject: Re: [PATCH 1/8] staging: android: binder: replace explicit size types Message-ID: <20130406060010.GA11127@kroah.com> References: <1365078758-28674-1-git-send-email-serban.constantinescu@arm.com> <1365078758-28674-2-git-send-email-serban.constantinescu@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 19 On Fri, Apr 05, 2013 at 04:17:47PM -0700, Arve Hj?nnev?g wrote: > On Thu, Apr 4, 2013 at 5:32 AM, Serban Constantinescu > wrote: > > > > Since the binder driver uses both uint32_t and unsigned int any further > > kernel changes will be difficult to read. This patch fixes the inconsistent > > types usage. > > > > Would it make more sense to only change the types that need to be > larger on a 64 bit system? I agree. You are also changing the type from explicit to "unexplicit", the exact opposite from what I would be expecting to see here. Why? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/