Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423172Ab3DFPHX (ORCPT ); Sat, 6 Apr 2013 11:07:23 -0400 Received: from mail-ea0-f176.google.com ([209.85.215.176]:57590 "EHLO mail-ea0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423040Ab3DFPHT (ORCPT ); Sat, 6 Apr 2013 11:07:19 -0400 Message-ID: <51603877.7070904@gmail.com> Date: Sat, 06 Apr 2013 17:00:07 +0200 From: Marco Stornelli User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130329 Thunderbird/17.0.5 MIME-Version: 1.0 To: Matthew Wilcox CC: linux-fsdevel@vger.kernel.org, Chris Mason , Alexander Viro , "Theodore Ts'o" , Andreas Dilger , Jaegeuk Kim , Steven Whitehouse , KONISHI Ryusuke , Mark Fasheh , Joel Becker , Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nilfs@vger.kernel.org, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara Subject: Re: [PATCH 3/4] fsfreeze: manage kill signal when sb_start_pagefault is called References: <515FF380.5020406@gmail.com> <20130406132028.GD28744@parisc-linux.org> In-Reply-To: <20130406132028.GD28744@parisc-linux.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1395 Lines: 36 Il 06/04/2013 15:20, Matthew Wilcox ha scritto: > On Sat, Apr 06, 2013 at 12:05:52PM +0200, Marco Stornelli wrote: >> In every place where sb_start_pagefault was called now we must manage >> the error code and return VM_FAULT_RETRY. > > Erm ... in patch 1/4: > > static inline void sb_start_pagefault(struct super_block *sb) > { > - __sb_start_write(sb, SB_FREEZE_PAGEFAULT, true); > + __sb_start_write_wait(sb, SB_FREEZE_PAGEFAULT, false); > } > >> >> - sb_start_pagefault(inode->i_sb); >> + ret = sb_start_pagefault(inode->i_sb); >> + if (ret) >> + return VM_FAULT_RETRY; >> ret = btrfs_delalloc_reserve_space(inode, PAGE_CACHE_SIZE); > > Does the compiler not warn that you're assigning void to 'ret'? Or was > there some other SNAFU sending these patches? > I'm sorry, my fault :) As I said in 00 these patches are completely *not* tested, it was only a "quick coding & review" to understand if someone can see any problem to this kind of implementation, since I touched several points in the kernel. So there is still on-going work and I need to do several tests. Maybe I had to add the RFC tag, sorry again. Marco -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/