Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1423312Ab3DFQ3N (ORCPT ); Sat, 6 Apr 2013 12:29:13 -0400 Received: from mail-bk0-f50.google.com ([209.85.214.50]:59951 "EHLO mail-bk0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423289Ab3DFQ3M (ORCPT ); Sat, 6 Apr 2013 12:29:12 -0400 Date: Sat, 6 Apr 2013 18:29:07 +0200 From: Robert Richter To: Borislav Petkov , LKML , Peter Zijlstra , Ingo Molnar , Frederic Weisbecker , Borislav Petkov Subject: Re: [RFC PATCH 2/3] perf: Add persistent event facilities Message-ID: <20130406162907.GG11652@rric.localhost> References: <1363352789-17991-1-git-send-email-bp@alien8.de> <1363352789-17991-3-git-send-email-bp@alien8.de> <20130328181516.GR11449@rric.localhost> <20130403172712.GA4716@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130403172712.GA4716@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 931 Lines: 23 On 03.04.13 19:27:12, Borislav Petkov wrote: > > > + list_for_each_entry(desc, &per_cpu(pers_events, cpu), plist) { > > > + > > > + if (desc->attr->config != attr->config) > > > + continue; > > > > Umm, the attr->config is not sufficient as a selector since it must be > > unique which is not granted (of course it works for one event only). > > Right, so the tracepoints are enumerated by tracing code at boot > time. But not the hw events, for example. How can we select events > unambiguously? As we discussed personally, in a first version we should allow only the tracepoint pmu to be used for persistent events. The config value is then unique and the above works. -Robert -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/