Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161172Ab3DFVup (ORCPT ); Sat, 6 Apr 2013 17:50:45 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:56504 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1161113Ab3DFVun (ORCPT ); Sat, 6 Apr 2013 17:50:43 -0400 Date: Sat, 6 Apr 2013 22:50:33 +0100 From: Al Viro To: Marco Stornelli Cc: Linux FS Devel , Chris Mason , Steve French , "Theodore Ts'o" , Andreas Dilger , Miklos Szeredi , Anton Altaparmakov , Mark Fasheh , Joel Becker , Ben Myers , Alex Elder , xfs@oss.sgi.com, Matthew Wilcox , Mike Snitzer , Alasdair G Kergon , linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-ext4@vger.kernel.org, fuse-devel@lists.sourceforge.net, linux-ntfs-dev@lists.sourceforge.net, ocfs2-devel@oss.oracle.com, linux-mm@kvack.org, Jan Kara Subject: Re: [PATCH 2/4] fsfreeze: manage kill signal when sb_start_write is called Message-ID: <20130406215033.GM4068@ZenIV.linux.org.uk> References: <515FF344.8040705@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <515FF344.8040705@gmail.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 649 Lines: 13 On Sat, Apr 06, 2013 at 12:04:52PM +0200, Marco Stornelli wrote: > In every place where sb_start_write was called now we must manage > the error code and return -EINTR. Now go and look for callers of mnt_want_write() ;-/ The really painful one is in do_last(), but kern_path_create() is not much better; mq_open() would be bad too, had it not been about something you are not going to freeze anyway... -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/