Message-id: <1365401875.4353.44.camel@kjgkr>
Subject: Re: [PATCH] F2FS: Fix the logic of IS_DNODE()
From: Jaegeuk Kim <jaegeuk.kim@samsung.com>
Reply-to: jaegeuk.kim@samsung.com
To: Zhihui Zhang <zzhsuny@gmail.com>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Date: Mon, 08 Apr 2013 15:17:55 +0900
In-reply-to: <1365353824-11745-1-git-send-email-zzhsuny@gmail.com>
References: <1365353824-11745-1-git-send-email-zzhsuny@gmail.com>
Organization: samsung
Content-type: multipart/signed; micalg=pgp-sha1;
 protocol="application/pgp-signature"; boundary="=-8Goebqn4pOazKR/Nj2g7"
MIME-version: 1.0
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2109
Lines: 67


--=-8Goebqn4pOazKR/Nj2g7
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi,

2013-04-07 (=EC=9D=BC), 12:57 -0400, Zhihui Zhang:
> Signed-off-by: Zhihui Zhang <zzhsuny@gmail.com>
> ---
>  fs/f2fs/node.h |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/fs/f2fs/node.h b/fs/f2fs/node.h
> index afdb130..2be47b2 100644
> --- a/fs/f2fs/node.h
> +++ b/fs/f2fs/node.h
> @@ -239,7 +239,7 @@ static inline bool IS_DNODE(struct page *node_page)
>  		return false;
>  	if (ofs >=3D 6 + 2 * NIDS_PER_BLOCK) {
>  		ofs -=3D 6 + 2 * NIDS_PER_BLOCK;
> -		if ((long int)ofs % (NIDS_PER_BLOCK + 1))
> +		if (!((long int)ofs % (NIDS_PER_BLOCK + 1)))

Great catch!
I'll apply this.
Thank you.

>  			return false;
>  	}
>  	return true;

--=20
Jaegeuk Kim
Samsung


--=-8Goebqn4pOazKR/Nj2g7
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.11 (GNU/Linux)

iQIcBAABAgAGBQJRYmETAAoJEEAUqH6CSFDSPRUQAISWMQTzErfk9ME1y//A0hAH
Kyx9Mbyu8xxXOQNiwHUra25DkOxvS1y0EUQIQLvYzuG5u78gmjaq3P6tRHEGs/G6
+pgXV5GRt1qWba9m02F5H4Qghu3i8ofUTzg5chz+rPBSGo4mVJUqDDgqTr7crMgJ
ie9B+y+9GUYmsBXL6pHb9PNKrjmBE7XE2dBKN8804ywU8wFz2aIMBcBUXzQSKgM+
2D4gNsrH6nJ2fFrJpFEN2csX03gxT2T4/IQlz938moMP9qpJ63JJHVSgg8f/y2DS
Iwo/R5XIn+7Q208tDtg5PleUZi0aLSVqBc4q7JM1hbxvLuOgq++WkgfdW1wJjHdW
l6aCl6rpjtE94o0hWKziQUA7MOEwiZNPyas3WJ5AcjQccoUVTm/Lnc7qWLQchGLv
9PMjif14EeJ7Ujk3S2SBRJDYBKYwmzPvCqYN3e+U+fzzK4GuMYBgtx61/e6AHuoM
ArzbMLFbHhAltfJvlZPbBGMSGw3nX0luHWa1UMTgwQfhVcEyQUZvq6RIstN7ADMy
qY4hAouXhW1h26qSUAlhU0OsTa6BAeyfT9zjBq8jpMfYj8lLfBXKjpUIx8h6n6tu
2Kg92Q5+gToI6qgFXnrOVHaerhot3ymMRqIE9noaNVQymLDQ+tpZeKXLxSZ3NNzu
eOFPLBD2xeOghFBgbkHD
=kBZ4
-----END PGP SIGNATURE-----

--=-8Goebqn4pOazKR/Nj2g7--

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/