Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755885Ab3DHG4l (ORCPT ); Mon, 8 Apr 2013 02:56:41 -0400 Received: from mail-qc0-f173.google.com ([209.85.216.173]:54442 "EHLO mail-qc0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752949Ab3DHG4k (ORCPT ); Mon, 8 Apr 2013 02:56:40 -0400 MIME-Version: 1.0 In-Reply-To: References: <1355933229-25865-1-git-send-email-christian.gmeiner@gmail.com> <20130124140746.GI12933@pengutronix.de> From: Christian Gmeiner Date: Mon, 8 Apr 2013 08:56:03 +0200 Message-ID: Subject: Re: [PATCH] at24: extend driver to allow writing via i2c_smbus_write_byte_data To: Wolfram Sang Cc: linux-i2c@vger.kernel.org, LKML , Christian Gmeiner Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2274 Lines: 62 Using the new mail address of wolfram sang - got the following error: Delivery to the following recipient failed permanently: w.sang@pengutronix.de Technical details of permanent failure: Google tried to deliver your message, but it was rejected by the server for the recipient domainpengutronix.de by mail.pengutronix.de. [2001:6f8:1178:4:290:27ff:fe1d:cc33]. The error that the other server returned was: 550 Account closed - please contact info@pengutronix.de instead 2013/3/27 Christian Gmeiner : > 2013/1/24 Wolfram Sang : >> On Wed, Dec 19, 2012 at 05:07:09PM +0100, Christian Gmeiner wrote: >>> I have a at24 EEPROM connected via i2c bus provided by ISCH i2c >>> bus driver. This bus driver does not support >>> I2C_FUNC_SMBUS_WRITE_I2C_BLOCK and so I was looking for a way >>> to be able to write the eeprom. This patch adds support for >>> I2C_SMBUS_BYTE_DATA writing via i2c_smbus_write_byte_data. >>> It is quite slow, but it works. >>> >>> Signed-off-by: Christian Gmeiner >>> --- >>> drivers/misc/eeprom/at24.c | 35 +++++++++++++++++++++++++++++------ >>> 1 file changed, 29 insertions(+), 6 deletions(-) >>> >>> diff --git a/drivers/misc/eeprom/at24.c b/drivers/misc/eeprom/at24.c >>> index 2baeec5..723b411 100644 >>> --- a/drivers/misc/eeprom/at24.c >>> +++ b/drivers/misc/eeprom/at24.c >>> @@ -56,6 +56,7 @@ struct at24_data { >>> struct at24_platform_data chip; >>> struct memory_accessor macc; >>> int use_smbus; >>> + int use_smbuse_write; >> >> Can't you use the same 'use_smbus' variable and do a similar switch-case >> as in the read function? >> > > Sorry for the really late answer. > > I am not sure if there exits some i2c buses which have different > access methods for read and write. > E.g. I2C_FUNC_SMBUS_WRITE_I2C_BLOCK and I2C_FUNC_SMBUS_READ_BYTE_DATA > > If there will never be such a combination then I can reuse the same > 'use_smbus' variable. > -- Christian Gmeiner, MSc -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/