Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935056Ab3DHIZP (ORCPT ); Mon, 8 Apr 2013 04:25:15 -0400 Received: from mail-la0-f52.google.com ([209.85.215.52]:36406 "EHLO mail-la0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934384Ab3DHIZM (ORCPT ); Mon, 8 Apr 2013 04:25:12 -0400 MIME-Version: 1.0 In-Reply-To: References: <1364457923-8499-1-git-send-email-amit.daniel@samsung.com> <1364457923-8499-2-git-send-email-amit.daniel@samsung.com> Date: Mon, 8 Apr 2013 13:55:10 +0530 X-Google-Sender-Auth: CIjTh1dV4oiFViDF48sAy7y8tPw Message-ID: Subject: Re: [PATCH V5 1/4] cpufreq: exynos: Add cpufreq driver for exynos5440 From: amit daniel kachhap To: Viresh Kumar Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Thomas Abraham , cpufreq@vger.kernel.org, Inderpal Singh , Sylwester Nawrocki , Russell King - ARM Linux Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1378 Lines: 34 On Thu, Mar 28, 2013 at 6:12 PM, Viresh Kumar wrote: > > On 28 March 2013 13:35, Amit Daniel Kachhap wrote: > > +++ b/drivers/cpufreq/exynos5440-cpufreq.c > > +static int exynos_cpufreq_cpu_init(struct cpufreq_policy *policy) > > +{ > > + policy->cur = dvfs_info->cur_frequency; > > + cpufreq_frequency_table_get_attr(dvfs_info->freq_table, policy->cpu); > > + > > + /* set the transition latency value */ > > + policy->cpuinfo.transition_latency = dvfs_info->latency; > > + > > + cpumask_setall(policy->cpus); > > + > > + return cpufreq_frequency_table_cpuinfo(policy, dvfs_info->freq_table); > > I missed this earlier and saw this mistake in yet another driver. > You need to call cpufreq_frequency_table_get_attr() only when > cpufreq_frequency_table_cpuinfo() has passed. ok. Submitted the V6 version with this change. > > > > +} > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/