Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934931Ab3DHIrL (ORCPT ); Mon, 8 Apr 2013 04:47:11 -0400 Received: from mail-oa0-f47.google.com ([209.85.219.47]:41031 "EHLO mail-oa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934401Ab3DHIrH (ORCPT ); Mon, 8 Apr 2013 04:47:07 -0400 MIME-Version: 1.0 In-Reply-To: <1365409058-32643-2-git-send-email-amit.daniel@samsung.com> References: <1365409058-32643-1-git-send-email-amit.daniel@samsung.com> <1365409058-32643-2-git-send-email-amit.daniel@samsung.com> Date: Mon, 8 Apr 2013 14:17:06 +0530 Message-ID: Subject: Re: [PATCH V6 1/4] cpufreq: exynos: Add cpufreq driver for exynos5440 From: Viresh Kumar To: Amit Daniel Kachhap Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Kukjin Kim , Thomas Abraham , cpufreq@vger.kernel.org, Inderpal Singh , Sylwester Nawrocki , Russell King - ARM Linux Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1918 Lines: 52 On 8 April 2013 13:47, Amit Daniel Kachhap wrote: > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index f3f3b14..bce2195 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -42,6 +42,15 @@ config ARM_EXYNOS5250_CPUFREQ > This adds the CPUFreq driver for Samsung EXYNOS5250 > SoC. > > +config ARM_EXYNOS5440_CPUFREQ > + def_bool SOC_EXYNOS5440 > + depends on HAVE_CLK && PM_OPP && OF Don't you need a depend on your Soc or mach or arch? Don't send another version for this now.. Just send a new patch over this patchset. > diff --git a/drivers/cpufreq/exynos5440-cpufreq.c b/drivers/cpufreq/exynos5440-cpufreq.c > +static int exynos_target(struct cpufreq_policy *policy, > + unsigned int target_freq, > + unsigned int relation) > +{ > + unsigned int index, tmp; > + int ret = 0, i; > + struct cpufreq_frequency_table *freq_table = dvfs_info->freq_table; > + > + mutex_lock(&cpufreq_lock); > + freqs.old = dvfs_info->cur_frequency; > + > + ret = cpufreq_frequency_table_target(policy, freq_table, > + target_freq, relation, &index); > + if (ret) > + goto out; > + Move freqs.old = *** here. > + freqs.new = freq_table[index].frequency; > + freqs.cpu = policy->cpu; You don't need this. Below call takes care of it. Rest is fine.. Just resend this patch with all above issues fixed and i will Ack it without any further reviews :) Don't wait for few days for doing this, send it right now. :) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/