Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934832Ab3DHJNE (ORCPT ); Mon, 8 Apr 2013 05:13:04 -0400 Received: from he.sipsolutions.net ([78.46.109.217]:52202 "EHLO sipsolutions.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754067Ab3DHJNB (ORCPT ); Mon, 8 Apr 2013 05:13:01 -0400 Message-ID: <1365412374.25475.2.camel@jlt4.sipsolutions.net> Subject: Re: [PATCH] mac80211_hwsim: Register and bind to driver From: Johannes Berg To: Martin Pitt Cc: "John W. Linville" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Dan Williams Date: Mon, 08 Apr 2013 11:12:54 +0200 In-Reply-To: <20130408090633.GB2818@piware.de> References: <20130408090633.GB2818@piware.de> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.6.3-1 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 583 Lines: 20 Looks fine, but ... > @@ -2179,6 +2183,8 @@ static int __init init_mac80211_hwsim(void) > if (IS_ERR(hwsim_class)) > return PTR_ERR(hwsim_class); > > + driver_register(&mac80211_hwsim_driver); > + > memset(addr, 0, ETH_ALEN); > addr[0] = 0x02; I think you forgot to update the error path to unregister the driver. johannes -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/