Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935177Ab3DHLis (ORCPT ); Mon, 8 Apr 2013 07:38:48 -0400 Received: from mail-wg0-f50.google.com ([74.125.82.50]:62884 "EHLO mail-wg0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934411Ab3DHLiq (ORCPT ); Mon, 8 Apr 2013 07:38:46 -0400 MIME-Version: 1.0 In-Reply-To: <51629B3D.4080905@ti.com> References: <1364903044-13752-1-git-send-email-prabhakar.csengg@gmail.com> <1364903044-13752-2-git-send-email-prabhakar.csengg@gmail.com> <51629B3D.4080905@ti.com> From: Prabhakar Lad Date: Mon, 8 Apr 2013 17:08:24 +0530 Message-ID: Subject: Re: [PATCH v2 1/3] media: davinci: vpss: enable vpss clocks To: Sekhar Nori Cc: DLOS , LAK , Mauro Carvalho Chehab , LMML , LKML Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 49 Sekhar, On Mon, Apr 8, 2013 at 3:56 PM, Sekhar Nori wrote: > On 4/2/2013 5:14 PM, Prabhakar lad wrote: >> From: Lad, Prabhakar >> >> By default the VPSS clocks were enabled in capture driver >> for davinci family which creates duplicates for dm355/dm365/dm644x. >> This patch adds support to enable the VPSS clocks in VPSS driver, >> which avoids duplication of code and also adding clock aliases. >> >> This patch uses PM runtime API to enable/disable instead common clock >> framework. con_ids for master and slave clocks of vpss is added in pm_domain > > Common clock framework in not (yet) used on DaVinci, so this is misleading. > OK, I'll make it 'This patch uses PM runtime API to enable/disable clock, instead of Davinci specific clock framework. con_ids for master and slave clocks of vpss is added in pm_domain' >> diff --git a/arch/arm/mach-davinci/pm_domain.c b/arch/arm/mach-davinci/pm_domain.c >> index c90250e..445b10b 100644 >> --- a/arch/arm/mach-davinci/pm_domain.c >> +++ b/arch/arm/mach-davinci/pm_domain.c >> @@ -53,7 +53,7 @@ static struct dev_pm_domain davinci_pm_domain = { >> >> static struct pm_clk_notifier_block platform_bus_notifier = { >> .pm_domain = &davinci_pm_domain, >> - .con_ids = { "fck", NULL, }, >> + .con_ids = { "fck", "master", "slave", NULL, }, > > NULL is sentinel so you can drop the ',' after that. Apart from that, > for the mach-davinci parts: > OK Regards, --Prabhakar > Acked-by: Sekhar Nori > > Thanks, > Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/