From: Kukjin Kim <kgene.kim@samsung.com>
To: "'Amit Daniel Kachhap'" <amit.daniel@samsung.com>,
        linux-pm@vger.kernel.org
Cc: "'Thomas Abraham'" <thomas.abraham@linaro.org>,
        "'Zhang Rui'" <rui.zhang@intel.com>, linux-samsung-soc@vger.kernel.org,
        linux-kernel@vger.kernel.org, amit.kachhap@gmail.com
References: <1364297642-2746-1-git-send-email-amit.daniel@samsung.com>
 <1364297642-2746-10-git-send-email-amit.daniel@samsung.com>
In-reply-to: <1364297642-2746-10-git-send-email-amit.daniel@samsung.com>
Subject: RE: [PATCH 9/9] ARM: dts: Add device tree node for exynos5440 TMU
 controller
Date: Mon, 08 Apr 2013 21:24:59 +0900
Message-id: <2d0d01ce3454$166aac70$43400550$%kim@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
Thread-index: Ac4qFfaVVeVy1IeUTo6Q7AvaawH4VwKPfOLQ
Content-language: ko
DLP-Filter: Pass
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2249
Lines: 91

Amit Daniel Kachhap wrote:
> 
> This patch adds device node for TMU controller. There are 3
> instances of the controllers so 3 nodes are created.
> 
> Signed-off-by: Amit Daniel Kachhap <amit.daniel@samsung.com>
> ---
>  arch/arm/boot/dts/exynos5440.dtsi |   43
> +++++++++++++++++++++++++++++++++++++
>  1 files changed, 43 insertions(+), 0 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/exynos5440.dtsi
> b/arch/arm/boot/dts/exynos5440.dtsi
> index 5f3562a..b74ce9f 100644
> --- a/arch/arm/boot/dts/exynos5440.dtsi
> +++ b/arch/arm/boot/dts/exynos5440.dtsi
> @@ -16,6 +16,12 @@
> 
>  	interrupt-parent = <&gic>;
> 
> +	aliases {
> +		tmuctrl0 = &tmuctrl_0;
> +		tmuctrl1 = &tmuctrl_1;
> +		tmuctrl2 = &tmuctrl_2;
> +	};
> +
>  	gic:interrupt-controller@2E0000 {
>  		compatible = "arm,cortex-a15-gic";
>  		#interrupt-cells = <3>;
> @@ -156,4 +162,41 @@
>  		reg = <0x130000 0x1000>;
>  		interrupts = <0 17 0>, <0 16 0>;
>  	};
> +
> +	tmu_ctrl_info: tmu-ctrl-info {
> +		gain = <5>;
> +		reference-voltage = <16>;
> +		noise-cancel-mode = <4>;
> +		cal-type = <2>;
> +		cal-mode = <0>;
> +		efuse-value = <0x5b2c>;
> +		threshold-falling = <5>;
> +	};
> +
> +	tmuctrl_0: tmuctrl@160118 {
> +		compatible = "samsung,exynos5440-tmu";
> +		reg = <0x160118 0x300>;
> +		interrupts = <0 58 0>;
> +		clocks = <&clock 8>;

Should be:
+		clocks = <&clock 21>;

> +		clock-names = "tmu_apbif";
> +		tmu-ctrl-data = <&tmu_ctrl_info>;
> +	};
> +
> +	tmuctrl_1: tmuctrl@16011C {
> +		compatible = "samsung,exynos5440-tmu";
> +		reg = <0x16011C 0x300>;
> +		interrupts = <0 58 0>;
> +		clocks = <&clock 8>;

+		clocks = <&clock 21>;

> +		clock-names = "tmu_apbif";
> +		tmu-ctrl-data = <&tmu_ctrl_info>;
> +	};
> +
> +	tmuctrl_2: tmuctrl@160120 {
> +		compatible = "samsung,exynos5440-tmu";
> +		reg = <0x160120 0x300>;
> +		interrupts = <0 58 0>;
> +		clocks = <&clock 8>;

+		clocks = <&clock 21>;

> +		clock-names = "tmu_apbif";
> +		tmu-ctrl-data = <&tmu_ctrl_info>;
> +	};
>  };
> --
> 1.7.1

- Kukjin

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/