Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935976Ab3DHMtT (ORCPT ); Mon, 8 Apr 2013 08:49:19 -0400 Received: from mail-la0-f54.google.com ([209.85.215.54]:46181 "EHLO mail-la0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935075Ab3DHMtQ (ORCPT ); Mon, 8 Apr 2013 08:49:16 -0400 MIME-Version: 1.0 X-Originating-IP: [93.172.123.88] In-Reply-To: <1365384999.31128.6.camel@fli24-HP-Compaq-8100-Elite-CMT-PC> References: <1362037031.6212.3.camel@fli24-HP-Compaq-8100-Elite-CMT-PC> <1362037455.6212.8.camel@fli24-HP-Compaq-8100-Elite-CMT-PC> <1365384999.31128.6.camel@fli24-HP-Compaq-8100-Elite-CMT-PC> From: Ohad Ben-Cohen Date: Mon, 8 Apr 2013 15:48:52 +0300 Message-ID: Subject: Re: [PATCH 2/5 V2] mmc: core: call pm_runtime_put_noidle in pm_runtime_get_sync failed case To: Li Fei Cc: Chris Ball , "ulf.hansson" , "johan.rudholm" , subhashj , "rafael.j.wysocki" , "thierry.reding" , "sachin.kamat" , "linux-mmc@vger.kernel.org" , "Rafael J. Wysocki" , "linux-kernel@vger.kernel.org" , Chuansheng Liu , "Coelho, Luciano" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 867 Lines: 22 On Mon, Apr 8, 2013 at 4:36 AM, Li Fei wrote: > Even in failed case of pm_runtime_get_sync, the usage_count > is incremented. In order to keep the usage_count with correct > value and runtime power management to behave correctly, call > pm_runtime_put_noidle in such case. > > Signed-off-by Liu Chuansheng > Signed-off-by: Li Fei Acked-by: Ohad Ben-Cohen BTW, Li, could you please move to _noidle in those other places where your previous patch was already applied? I think we have at least the 12xx driver (cc'ing Luca). Thanks! Ohad. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/