Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935172Ab3DHSE4 (ORCPT ); Mon, 8 Apr 2013 14:04:56 -0400 Received: from na3sys009aog125.obsmtp.com ([74.125.149.153]:44036 "EHLO na3sys009aog125.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934838Ab3DHSEy (ORCPT ); Mon, 8 Apr 2013 14:04:54 -0400 X-Greylist: delayed 326 seconds by postgrey-1.27 at vger.kernel.org; Mon, 08 Apr 2013 14:04:54 EDT From: Bing Zhao To: Ben Hutchings , Greg Kroah-Hartman CC: "linux-kernel@vger.kernel.org" , "stable@vger.kernel.org" , Marco Cesarano , "John W. Linville" Date: Mon, 8 Apr 2013 10:58:39 -0700 Subject: RE: [ 14/56] mwifiex: cancel cmd timer and free curr_cmd in shutdown process Thread-Topic: [ 14/56] mwifiex: cancel cmd timer and free curr_cmd in shutdown process Thread-Index: Ac4zAMs33yv0zm/CTY2RIqFFKsAqswBgYmHA Message-ID: <477F20668A386D41ADCC57781B1F70430D9DE96059@SC-VEXCH1.marvell.com> References: <20130402224711.840825715@linuxfoundation.org> <20130402224713.540410031@linuxfoundation.org> <1365278155.2840.61.camel@deadeye.wl.decadent.org.uk> In-Reply-To: <1365278155.2840.61.camel@deadeye.wl.decadent.org.uk> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: acceptlanguage: en-US Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id r38I55Q6029444 Content-Length: 967 Lines: 31 Hi Ben, Greg, > > From: Bing Zhao > > > > commit 084c7189acb3f969c855536166042e27f5dd703f upstream. > > > > curr_cmd points to the command that is in processing or waiting > > for its command response from firmware. If the function shutdown > > happens to occur at this time we should cancel the cmd timer and > > put the command back to free queue. > > > > Tested-by: Marco Cesarano > > Signed-off-by: Bing Zhao > > Signed-off-by: John W. Linville > > Signed-off-by: Greg Kroah-Hartman > > This also had: > > Cc: # 3.8 > > so I wonder whether this is good/bad/indifferent for 3.0.y. Please drop this patch from stable kernel < 3.8. Thanks, Bing > > Ben. ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?