Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935684Ab3DHTHL (ORCPT ); Mon, 8 Apr 2013 15:07:11 -0400 Received: from www.sr71.net ([198.145.64.142]:43306 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762969Ab3DHTHJ (ORCPT ); Mon, 8 Apr 2013 15:07:09 -0400 Message-ID: <5163155D.7030401@sr71.net> Date: Mon, 08 Apr 2013 12:07:09 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130308 Thunderbird/17.0.4 MIME-Version: 1.0 To: "Kirill A. Shutemov" CC: Andrea Arcangeli , Andrew Morton , Al Viro , Hugh Dickins , Wu Fengguang , Jan Kara , Mel Gorman , linux-mm@kvack.org, Andi Kleen , Matthew Wilcox , "Kirill A. Shutemov" , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCHv3, RFC 32/34] thp: handle write-protect exception to file-backed huge pages References: <1365163198-29726-1-git-send-email-kirill.shutemov@linux.intel.com> <1365163198-29726-33-git-send-email-kirill.shutemov@linux.intel.com> In-Reply-To: <1365163198-29726-33-git-send-email-kirill.shutemov@linux.intel.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 940 Lines: 21 For all the do_huge_pmd_wp_page(), I think we need a better description of where the code came from. There are some more obviously copy-n-pasted comments in there. For the entire series, in the patch description, we need to know: 1. What was originally written and what was copied from elsewhere 2. For the stuff that was copied, was an attempt made to consolidate instead of copy? Why was consolidation impossible or infeasible? > + if (!PageAnon(page)) { > + add_mm_counter(mm, MM_FILEPAGES, -HPAGE_PMD_NR); > + add_mm_counter(mm, MM_ANONPAGES, HPAGE_PMD_NR); > + } This seems like a bit of a hack. Shouldn't we have just been accounting to MM_FILEPAGES in the first place? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/