Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935771Ab3DHTlb (ORCPT ); Mon, 8 Apr 2013 15:41:31 -0400 Received: from mail-lb0-f169.google.com ([209.85.217.169]:45250 "EHLO mail-lb0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1763205Ab3DHTl3 (ORCPT ); Mon, 8 Apr 2013 15:41:29 -0400 MIME-Version: 1.0 In-Reply-To: <2824266.emLkgITIHc@flatron> References: <1365439879-3398-1-git-send-email-dianders@chromium.org> <51630C7C.9040003@gmail.com> <2824266.emLkgITIHc@flatron> Date: Mon, 8 Apr 2013 12:41:28 -0700 X-Google-Sender-Auth: xrqlGeatVBKNicWQ0_fSBpGAaNI Message-ID: Subject: Re: [PATCH] ARM: dts: fix bad merge of display timing node to exynos5250-smdk5250.dts From: Doug Anderson To: Tomasz Figa Cc: "linux-arm-kernel@lists.infradead.org" , Kukjin Kim , linux-samsung-soc@vger.kernel.org, Russell King , Leela Krishna Amudala , Jingoo Han , "linux-kernel@vger.kernel.org" , Kukjin Kim , Thomas Abraham , Olof Johansson , Rahul Sharma Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1393 Lines: 32 Tomasz, On Mon, Apr 8, 2013 at 12:27 PM, Tomasz Figa wrote: > Common Clock Framework by default automatically gates unused clocks, just > like regulator core does with unused regulators. Maybe this is the cause? Yes, I'm nearly certain that's the case here. The reset code doesn't belong to any driver (it's in mach-exynos/common.c) it certainly doesn't grab any clock. I tried quickly to see if there was an easy clock to grab but got a bit stuck. In the old way of doing things clocks could be global and grabbed without a dev node. That may still be possible now, but in the 15 minutes I spent I couldn't figure it out and so it went to the back burner. ...or we could make a real reset device, but that might be overkill? > There is a CLK_IGNORE_UNUSED flag which disables this behavior for all > clocks which have it set. Maybe it should be set for the problematic > clock? Didn't know about that one, thanks! It seems like a bit annoying that we'd have to keep this clock all the time just to get reset working, though. I guess in 3.4 that's what we did, though I don't know if it was intentional... -Doug -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/