Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S936031Ab3DHU0d (ORCPT ); Mon, 8 Apr 2013 16:26:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34907 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1762703Ab3DHU0b (ORCPT ); Mon, 8 Apr 2013 16:26:31 -0400 Date: Mon, 08 Apr 2013 16:25:29 -0400 From: Naoya Horiguchi To: KOSAKI Motohiro Cc: linux-mm@kvack.org, Andrew Morton , Mel Gorman , Hugh Dickins , KOSAKI Motohiro , Andi Kleen , Hillf Danton , Michal Hocko , linux-kernel@vger.kernel.org Message-ID: <1365452729-dczpcd7w-mutt-n-horiguchi@ah.jp.nec.com> In-Reply-To: <515F4D9A.3060009@gmail.com> References: <1363983835-20184-1-git-send-email-n-horiguchi@ah.jp.nec.com> <1363983835-20184-8-git-send-email-n-horiguchi@ah.jp.nec.com> <515F4D9A.3060009@gmail.com> Subject: Re: [PATCH 07/10] mbind: add hugepage migration code to mbind() Mime-Version: 1.0 Content-Type: text/plain; charset=iso-2022-jp Content-Transfer-Encoding: 7bit Content-Disposition: inline X-Mutt-References: <515F4D9A.3060009@gmail.com> X-Mutt-Fcc: ~/Maildir/sent/ User-Agent: Mutt 1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 794 Lines: 20 On Fri, Apr 05, 2013 at 06:18:02PM -0400, KOSAKI Motohiro wrote: > > @@ -1277,14 +1279,10 @@ static long do_mbind(unsigned long start, unsigned long len, > > if (!err) { > > int nr_failed = 0; > > > > - if (!list_empty(&pagelist)) { > > - WARN_ON_ONCE(flags & MPOL_MF_LAZY); > > - nr_failed = migrate_pages(&pagelist, new_vma_page, > > + WARN_ON_ONCE(flags & MPOL_MF_LAZY); > > ??? > MPOL_MF_LAZY always output warn? It seems really insane. So I'll stop replacing this block into migrate_movable_pages() and leave this WARN as it is. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/