Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935568Ab3DIDuJ (ORCPT ); Mon, 8 Apr 2013 23:50:09 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:43182 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752514Ab3DIDuH (ORCPT ); Mon, 8 Apr 2013 23:50:07 -0400 MIME-Version: 1.0 In-Reply-To: <1365479133.6865.1.camel@joe-AO722> References: <1363165944-7480-1-git-send-email-sachin.kamat@linaro.org> <1365476945.2012.2.camel@joe-AO722> <1365479133.6865.1.camel@joe-AO722> Date: Tue, 9 Apr 2013 09:20:06 +0530 Message-ID: Subject: Re: [PATCH 1/1] irqchip: exynos-combiner: Fix checkpatch warnings From: Sachin Kamat To: Joe Perches Cc: linux-kernel@vger.kernel.org, tglx@linutronix.de, patches@linaro.org, chanho61.park@samsung.com, kgene.kim@samsung.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1927 Lines: 51 On 9 April 2013 09:15, Joe Perches wrote: > On Tue, 2013-04-09 at 09:06 +0530, Sachin Kamat wrote: >> On 9 April 2013 08:39, Joe Perches wrote: >> > On Tue, 2013-04-09 at 08:33 +0530, Sachin Kamat wrote: >> >> On 13 March 2013 14:42, Sachin Kamat wrote: >> >> > Fixes the following warnings: >> >> > WARNING: line over 80 characters >> >> > WARNING: Prefer pr_warn(... to pr_warning(... >> >> > diff --git a/drivers/irqchip/exynos-combiner.c b/drivers/irqchip/exynos-combiner.c >> > [] >> >> > @@ -229,13 +229,15 @@ void __init combiner_init(void __iomem *combiner_base, >> > [] >> >> > - pr_warning("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", __func__, irq_base); >> >> > + pr_warn("%s: irq desc alloc failed. " >> >> > + "Continuing with %d as linux irq base\n", >> >> > + __func__, irq_base); >> > >> > Please don't split formats. >> > See Documentation/CodingStyle Chapter 2 >> > >> > pr_warn("%s: irq desc alloc failed. Continuing with %d as linux irq base\n", >> > __func__, irq_base); >> > >> > >> >> Thanks for pointing out. If I didn't split it, it would have exceeded >> the 80 column limit. > > So? Removing one would have introduced another :) > >> Since there were 2 different sentences, I thought >> grepping should not be a problem if split at sentence boundaries. > > I think it's OK to split at \n but not necessarily > at a sentence boundary/period. OK, I will use the format suggested by you and re-submit. Thanks for reviewing. -- With warm regards, Sachin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/