Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935382Ab3DIHCG (ORCPT ); Tue, 9 Apr 2013 03:02:06 -0400 Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:46908 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760401Ab3DIHCE (ORCPT ); Tue, 9 Apr 2013 03:02:04 -0400 Date: Tue, 9 Apr 2013 09:01:39 +0200 From: Jens Axboe To: Dave Chinner Cc: Phillip Susi , CAI Qian , xfs@oss.sgi.com, LKML Subject: Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78] Message-ID: <20130409070139.GS12244@kernel.dk> References: <20130402071937.GC3670@kernel.dk> <20130402073035.GD3670@kernel.dk> <14055702.547701.1364891947331.JavaMail.root@redhat.com> <20130402090047.GF3670@kernel.dk> <985125161.581860.1364895066584.JavaMail.root@redhat.com> <20130402094834.GA4667@kernel.dk> <20130403114142.GP4667@kernel.dk> <515C4D9D.10103@ubuntu.com> <515DE2FE.1080201@ubuntu.com> <20130409065519.GH17758@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130409065519.GH17758@dastard> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1463 Lines: 38 On Tue, Apr 09 2013, Dave Chinner wrote: > On Thu, Apr 04, 2013 at 04:30:54PM -0400, Phillip Susi wrote: > > > I have not tested it yet, but I am pretty sure it won't work. It > > > looks like the patch changes the BLKRRPART path to go ahead and remove > > > existing partitions when GENHD_FL_NO_PARTSCAN is set. loop doesn't > > > issue the BLKRRPART ioctl when !LO_FLAGS_PARTSCAN so this won't help. > > > I think loop needs to set GENHD_FL_NO_PARTSCAN and then issue the > > > ioctl regardless of the LO_FLAGS_PARTSCAN flag to get the partitions > > > to be removed. I will try to test tonight. > > > > After testing, my initial thoughts appeared to have been correct. I had > > to modify the patch as follows. To test, simply do: > > > > truncate -s 10m img > > losetup /dev/loop0 img > > parted /dev/loop0 > > mklabel msdos > > mkpart primary ext2 1m 2m > > quit > > ls /dev/loop0* > > > > Note the /dev/loop0p1 node. Run losetup -d /dev/loop0 and see if it is > > still there. > > Jens, can we get one of these fixes merged quickly? xfstests is > unusable on any kernel more recent than 3.9-rc4 because of these > problems.... Yep, did the revert yesterday and it's going out today. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/