Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S937096Ab3DIIXI (ORCPT ); Tue, 9 Apr 2013 04:23:08 -0400 Received: from mail-ie0-f178.google.com ([209.85.223.178]:43043 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936058Ab3DIIXF (ORCPT ); Tue, 9 Apr 2013 04:23:05 -0400 MIME-Version: 1.0 In-Reply-To: <1364310754-3692-3-git-send-email-kgene.kim@samsung.com> References: <1364310754-3692-1-git-send-email-kgene.kim@samsung.com> <1364310754-3692-3-git-send-email-kgene.kim@samsung.com> Date: Tue, 9 Apr 2013 10:23:03 +0200 Message-ID: Subject: Re: [PATCH 2/3] pinctrl: exynos5440: add gpio interrupt support From: Linus Walleij To: Kukjin Kim Cc: linux-samsung-soc , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Thomas Abraham Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1974 Lines: 57 On Tue, Mar 26, 2013 at 4:12 PM, Kukjin Kim wrote: > From: Thomas Abraham > > Exynos5440 supports gpio interrupts on gpios 16 to 23. The eight interrupt lines > originating from the pin-controller are connected to the gic. Add irq-chip support > for these interrupts. > > Signed-off-by: Thomas Abraham > Cc: Linus Walleij > Signed-off-by: Kukjin Kim Basically really nice. Patch has been applied, but some comments for future reference: > +/* gpiolib gpio_to_irq callback function */ > +static int exynos5440_gpio_to_irq(struct gpio_chip *gc, unsigned offset) > +{ > + struct exynos5440_pinctrl_priv_data *priv = dev_get_drvdata(gc->dev); > + unsigned int virq; I'm a bit annoyed by use of the abbreviation "virq" as if the IRQs were "virtual", they are not - this implies that the Linux IRQ numbers are not "real" or something. I use the nomenclature: irq = Linux IRQ hwirq = whatever offset that IRQ has in the hardware IRQ controller. virq I think is confusing... > +static irqreturn_t exynos5440_gpio_irq(int irq, void *data) > +{ > + struct exynos5440_gpio_intr_data *intd = data; > + struct exynos5440_pinctrl_priv_data *d = intd->priv; > + int virq; > + > + virq = irq_linear_revmap(d->irq_domain, intd->gpio_int); > + if (!virq) > + return IRQ_NONE; > + generic_handle_irq(virq); > + return IRQ_HANDLED; > +} Same here. Actually, I guess irq_linear_revmap works here, but irq_find_mapping(domain, hwirq) is more archaic, could you test if that works as well and make a follow-up patch to change it? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/