Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934529Ab3DIIqU (ORCPT ); Tue, 9 Apr 2013 04:46:20 -0400 Received: from mail-ie0-f169.google.com ([209.85.223.169]:51714 "EHLO mail-ie0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751809Ab3DIIqQ (ORCPT ); Tue, 9 Apr 2013 04:46:16 -0400 MIME-Version: 1.0 In-Reply-To: <1365441321-21952-3-git-send-email-kevin.strasser@linux.intel.com> References: <1365441321-21952-1-git-send-email-kevin.strasser@linux.intel.com> <1365441321-21952-3-git-send-email-kevin.strasser@linux.intel.com> Date: Tue, 9 Apr 2013 10:46:15 +0200 Message-ID: Subject: Re: [PATCH 3/4] gpio: Kontron PLD gpio driver From: Linus Walleij To: Kevin Strasser Cc: "linux-kernel@vger.kernel.org" , Michael Brunner , Samuel Ortiz , Wolfram Sang , Ben Dooks , "linux-i2c@vger.kernel.org" , Grant Likely , Wim Van Sebroeck , linux-watchdog@vger.kernel.org, Darren Hart , Michael Brunner , Greg Kroah-Hartman Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 934 Lines: 31 On Mon, Apr 8, 2013 at 7:15 PM, Kevin Strasser wrote: > From: Michael Brunner > > Add gpio support for the on-board PLD found on some Kontron embedded > modules. > > Signed-off-by: Michael Brunner > Signed-off-by: Kevin Strasser This looks very generic, setting and clearing bits in bytesized registers. Can you please attempt to use generic GPIO for this? drivers/gpio/gpio-generic.c See for example: gpio-ep93xx.c, gpio-sodaville.c ... Since you don't even have IRQ support in this it will be even simpler. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/