Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935618Ab3DINCa (ORCPT ); Tue, 9 Apr 2013 09:02:30 -0400 Received: from mail-bk0-f48.google.com ([209.85.214.48]:48125 "EHLO mail-bk0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759206Ab3DINC3 (ORCPT ); Tue, 9 Apr 2013 09:02:29 -0400 MIME-Version: 1.0 In-Reply-To: <51640A16.1060002@cogentembedded.com> References: <1365499312-14232-1-git-send-email-gautam.vivek@samsung.com> <51640A16.1060002@cogentembedded.com> Date: Tue, 9 Apr 2013 18:32:27 +0530 Message-ID: Subject: Re: [PATCH] usb: ehci-s5p: fix: Fix null pointer dereferencing From: Vivek Gautam To: Sergei Shtylyov Cc: Vivek Gautam , linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, gregkh@linuxfoundation.org, stern@rowland.harvard.edu, kgene.kim@samsung.com, Manjunath Goudar , Arnd Bergmann , Jingoo Han Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1158 Lines: 47 Hi, On Tue, Apr 9, 2013 at 6:01 PM, Sergei Shtylyov wrote: > Hello. > > > On 09-04-2013 13:21, Vivek Gautam wrote: > >> 7edb3da makes ehci-s5p as a separate driver. But, > > > Please also provide the summary line of that commit in parens. Sure, will add the commit line of that patch. > > >> it raised an issue with its driver data. >> Now that 's5p_ehci_hcd' doesn't maintain pointer to 'usb_hcd' >> and s5p_ehci is nothing but a pointer to hcd->priv; >> add hcd to the driver data rather than s5p_ehci. > > >> This fixes issues with null pointer dereferencing in >> s5p_ehci_shutdown(), s5p_ehci_suspend(), s5p_ehci_resume(). > > >> Signed-off-by: Vivek Gautam >> CC: Manjunath Goudar >> CC: Arnd Bergmann >> CC: Jingoo Han > > > WBR, Sergei -- Thanks & Regards Vivek -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/